Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-24 Thread Michael Koch
Please consider sending a patch that updates the documentation. I recommend to make the following changes in chapter 38.73.1: The filter accepts the following options: cx Relative x-coordinate of the center of the distortion. This value has a range [0,1] and is expressed as fractions of

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Carl Eugen Hoyos
Michael Koch t-online.de> writes: > The formula is correct, but it must be clarified that it > describes the behaviour of the lens. It does not describe > the behaviour of the lenscorrection filter. Please consider sending a patch that updates the documentation. Carl Eugen __

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Michael Koch
Am 23.02.2016 um 18:51 schrieb Michael Koch: r_src is the radial coordinate in object space. r_tgt is the radial coordinate in the image, which was taken with a distorted lens. Sorry, I confused these two. This is correct: r_tgt is the radial coordinate in object space. r_src is the radial co

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Michael Koch
Am 23.02.2016 um 10:00 schrieb Michael Koch: I found a bug in the documentation of the lenscorrection filter: https://www.ffmpeg.org/ffmpeg-all.html#lenscorrection It's written there "0.5 means no correction" for the coefficients k1 and k2. This can't be right, or the formula is wrong. It's o

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Michael Koch
I can't help you much, but you are free to look at the source code, and see whether you can see the formula from it: https://github.com/FFmpeg/FFmpeg/blob/master/libavfilter/vf_lenscorrection.c I did already try that, but there are no comments in the source code, and it's really difficult to u

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Moritz Barsnick
On Tue, Feb 23, 2016 at 10:00:47 +0100, Michael Koch wrote: > The remarks "0.5 means no correction" in the documentation are wrong. > This can easily be tested: I know nothing about lens correction formulas, I trust you on this. :-) > But unfortunately this isn't the only error in the documentat

Re: [FFmpeg-user] lenscorrection and vignette filters

2016-02-23 Thread Michael Koch
I found a bug in the documentation of the lenscorrection filter: https://www.ffmpeg.org/ffmpeg-all.html#lenscorrection It's written there "0.5 means no correction" for the coefficients k1 and k2. This can't be right, or the formula is wrong. It's obvious that the formula makes no correction i

[FFmpeg-user] lenscorrection and vignette filters

2016-02-02 Thread Michael Koch
Hi all, I found a bug in the documentation of the lenscorrection filter: https://www.ffmpeg.org/ffmpeg-all.html#lenscorrection It's written there "0.5 means no correction" for the coefficients k1 and k2. This can't be right, or the formula is wrong. It's obvious that the formula makes no corre