Re: [FFmpeg-user] Stereoscopic hwaccel

[JackDesBwa]

2019-10-03 09:56, JackDesBwa:
> 2019-10-03 01:23, Mark Thompson :
> > On 17/09/2019 17:33, JackDesBwa wrote:
> > > Hi,
> > >
> > > I do stereoscopic (3d) photography for a few years and I just start to
> > > experiment on stereoscopic videos.
> > > The filter_complex argument of ffmpeg allows me to do the editing I have 
> > > in
> > > mind more precisely and less painfully than I was able to do with regular
> > > non-linear editors before.
> > > Now that the basic editing tools seem to be right for my video projects, I
> > > want to accelerate rendering with hardware, and here starts my question.
> > >
> > > *How to have frame-packing information in h264 streams when generated with
> > > hardware acceleration?*
> > >
> > > ...
> > > Accelerating with vaapi:
> > > ffmpeg -vaapi_device /dev/dri/renderD128 -hwaccel vaapi
> > > -hwaccel_output_format vaapi -i aligned/l_01.mp4 -i aligned/r_01.mp4
> > > -filter_complex '[0][1]framepack=sbs,format=nv12|vaapi,hwupload' -c:v
> > > h264_vaapi -qp 22 -profile:v high out_vaapi.mp4
> >
> > Try this with 
> > .
>
> Wow, thanks to have worked on it.
> Sure I can try the patch to confirm it works, but you might have to help me.
>
> 1. This patch seems to be in a series. Should I apply the whole series
> or only this patch would suffice?
> 2. On which base should I apply it/them? Only master seems to be
> recent, but it does not have your patches yet.
> 3. In this patch, you do not use av_frame_get_side_data(frame,
> AV_FRAME_DATA_STEREO3D) as in libx264.c codec, but I see you added a
> frame_packing. Does it mean I have to add an option in the command
> line?

Mark Thompson, you did not answered my questions.
As your code is still not on master, I cannot test to confirm if your
patch is working without your instructions.

JackDesBwa
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-user] drawgraph filter, color formats

[JackDesBwa]

> > Well, in the documentation is a chapter about colors and the format is
> > described as 0xRRGGBB[AA].
> > However in the documentation for the drawgraph filter is written "The
> > color is defined as 0xAABBGGRR". So it's impossible to use the
> > predefined colors in this filter.
> > In the documentation should be a warning that the "bg" parameter must be
> > in 0xRRGGBBAA format.
> > But in my opinion changing the code is the better solution.
>
> Code will NOT be changed.

You are right!
When there is an obvious interface bug like this, especially when it
introduces inconsistency, it shall never be corrected.
PHP is a good example that this way of doing is a very successful path
without any downside at all.
Everyone should understand that code is the best specification and
bugs that don't make things crash are to be understood as special
features (that way, we gain a lot of time)
Moreover, backward compatibility is more important than correctness,
and it is up to the users to learn all the defects that might have
been introduced in the past and add extra code on his side to overcome
the corner cases of the software they use underneath.
Deprecating wrong ways to introduce nicer alternatives is so much
time-consuming that I wonder how the project which choose this can
handle the extra work.

Thus for sure, such silly proposition to correct this interesting kind
of features deserves a definitive answer with capital letters and no
explanation at all.

JackDesBwa :-/
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-user] drawgraph filter, color formats

[Paul B Mahol]

On 11/3/19, Michael Koch  wrote:
> Am 03.11.2019 um 06:55 schrieb Carl Eugen Hoyos:
>> Am So., 3. Nov. 2019 um 00:08 Uhr schrieb Michael Koch
>> :
>>
>>> I'm just making some experiments with the drawgraph filter and it took
>>> me more than one hour to figure out what was wrong:
>>> The colors of the graphs must be specified in format 0xAABBGGRR, but the
>>> background color must be in format 0xRRGGBBAA.
>>> That's very confusing!
>> Sounds like a bug to me but changing the code will break existing
>> scripts;-(
>>
>
> Well, in the documentation is a chapter about colors and the format is
> described as 0xRRGGBB[AA].
> However in the documentation for the drawgraph filter is written "The
> color is defined as 0xAABBGGRR". So it's impossible to use the
> predefined colors in this filter.
> In the documentation should be a warning that the "bg" parameter must be
> in 0xRRGGBBAA format.
> But in my opinion changing the code is the better solution.

Code will NOT be changed.

>
> Michael
> ___
> ffmpeg-user mailing list
> ffmpeg-user@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-user
>
> To unsubscribe, visit link above, or email
> ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-user] drawgraph filter, color formats

[Michael Koch]

Am 03.11.2019 um 06:55 schrieb Carl Eugen Hoyos:

Am So., 3. Nov. 2019 um 00:08 Uhr schrieb Michael Koch
:


I'm just making some experiments with the drawgraph filter and it took
me more than one hour to figure out what was wrong:
The colors of the graphs must be specified in format 0xAABBGGRR, but the
background color must be in format 0xRRGGBBAA.
That's very confusing!

Sounds like a bug to me but changing the code will break existing scripts;-(



Well, in the documentation is a chapter about colors and the format is 
described as 0xRRGGBB[AA].
However in the documentation for the drawgraph filter is written "The 
color is defined as 0xAABBGGRR". So it's impossible to use the 
predefined colors in this filter.
In the documentation should be a warning that the "bg" parameter must be 
in 0xRRGGBBAA format.

But in my opinion changing the code is the better solution.

Michael
___
ffmpeg-user mailing list
ffmpeg-user@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-user

To unsubscribe, visit link above, or email
ffmpeg-user-requ...@ffmpeg.org with subject "unsubscribe".