Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Julian Gardner
On 2019-09-17 17:35, Nicolas George wrote: Julian Gardner (12019-09-17): No its meant to parse anything, not just strings I assure you, it is meant to parse strings. The name of the file should be a hint. It has been abused to parse anything, but it is meant for strings. Fixing the

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Julian Gardner
You mean like this diff --git a/libavutil/avstring.c b/libavutil/avstring.c index 4c068f5..8a264c0 100644 --- a/libavutil/avstring.c +++ b/libavutil/avstring.c @@ -150,14 +150,26 @@ char *av_get_token(const char **buf, const char *term) { char *out = av_malloc(strlen(*buf) + 1);

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Nicolas George
Julian Gardner (12019-09-17): > No its meant to parse anything, not just strings I assure you, it is meant to parse strings. The name of the file should be a hint. It has been abused to parse anything, but it is meant for strings. Fixing the problem with escaping needs to rework the problem

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Julian Gardner
On 2019-09-17 17:25, Nicolas George wrote: Julian Gardner (12019-09-17): Not balanced, can you please give me an example so I can look into the problem. I can think of only one case and that would be someone using braces inside a text field? Exactly. The function you are proposing to

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Nicolas George
Julian Gardner (12019-09-17): > Not balanced, can you please give me an example so I can look into the > problem. > > I can think of only one case and that would be someone using braces inside a > text field? Exactly. The function you are proposing to change is meant to parse strings. Giving it

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Julian Gardner
On 2019-09-17 12:52, Nicolas George wrote: Julian Gardner (12019-09-17): Can you show me a case where this will cause a failure as all my filters work as they should. Bear in mind this only fixes the cases where escaping is required inside parenthesis. It will fail everywhere parentheses

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Nicolas George
Julian Gardner (12019-09-17): > Can you show me a case where this will cause a failure as all my filters > work as they should. > > Bear in mind this only fixes the cases where escaping is required inside > parenthesis. It will fail everywhere parentheses are not supposed to be balanced.

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Julian Gardner
On 2019-09-17 11:42, Nicolas George wrote: Julian Gardner (12019-09-16): A few weeks ago I had a problem with some eval code and it was pointed out that i need to escape the ','. So here is a small patch that needs passing on to the devel guys to have a look at. All this does is to ignore

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-17 Thread Nicolas George
Julian Gardner (12019-09-16): > A few weeks ago I had a problem with some eval code and it was pointed out > that i need to escape the ','. > > So here is a small patch that needs passing on to the devel guys to have a > look at. > > All this does is to ignore the fixed tokens when inside

Re: [FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-16 Thread Carl Eugen Hoyos
Am Mo., 16. Sept. 2019 um 22:41 Uhr schrieb Julian Gardner : > > A few weeks ago I had a problem with some eval code and it was pointed > out that i need to escape the ','. > > So here is a small patch that needs passing on to the devel guys to have > a look at. > > All this does is to ignore the

[FFmpeg-user] changes to ffmpeg to stop having to put an escape

2019-09-16 Thread Julian Gardner
A few weeks ago I had a problem with some eval code and it was pointed out that i need to escape the ','. So here is a small patch that needs passing on to the devel guys to have a look at. All this does is to ignore the fixed tokens when inside parenthesis, so this works now