Re: [Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Jiří Činčura
>DDL_TRIGGER_BEFORE | TRIGGER_TYPE_DDL | (1 << > DDL_TRIGGER_CREATE_TABLE) | (1 << DDL_TRIGGER_ALTER_TABLE) = Yes, that's what I eventually found in parse.y, but doesn't it make sense to have this fromula in the comment? BEcause what's there now isn't helpful at all. -- Mgr. Jiří Činčura h

[Firebird-devel] [FB-Tracker] Created: (CORE-6058) Change behavior of skipped and repeated wall times within time zones

2019-05-01 Thread Adriano dos Santos Fernandes (JIRA)
Change behavior of skipped and repeated wall times within time zones Key: CORE-6058 URL: http://tracker.firebirdsql.org/browse/CORE-6058 Project: Firebird Core Issue Type:

Re: [Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Vlad Khorsun
01.05.2019 20:56, Jiří Činčura wrote: Somebody check my math for "before alter table or create table": (TRIGGER_TYPE_DDL | DDL_TRIGGER_{AFTER | BEFORE} [ | DDL_TRIGGER_??? ...]) => 16384 | 0 | 2 | 1 => 16387 I see now what is confusing - there is no explicit sign that DDL_TRIGGER_XXX is a num

Re: [Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Jiří Činčura
Somebody check my math for "before alter table or create table": (TRIGGER_TYPE_DDL | DDL_TRIGGER_{AFTER | BEFORE} [ | DDL_TRIGGER_??? ...]) => 16384 | 0 | 2 | 1 => 16387 Yet in RDB$TRIGGERS 16390 is stored. Also funny enough the "after alter table or create table" aka 16384 | 1 | 2 | 1 gives sam

Re: [Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Jiří Činčura
The formula in the highlighted comment doesn't seem to describe what is actually computed and stored. -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ On Wed, May 1, 2019, at 15:55, Vlad Khorsun wrote: > 01.05.2019 15:47, Jiří Činčura wrote: > > Hi *, > > > > I'm looking into constants.h a

Re: [Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Vlad Khorsun
01.05.2019 15:47, Jiří Činčura wrote: Hi *, I'm looking into constants.h and I see this https://github.com/FirebirdSQL/firebird/blob/master/src/jrd/constants.h#L449 . But this does not seem to be what the parse.y is doing nor what I see in RDB$TRIGGERS. Can somebody check it? I don't see wh

[Firebird-devel] DDL trigger values formula in constants.h

2019-05-01 Thread Jiří Činčura
Hi *, I'm looking into constants.h and I see this https://github.com/FirebirdSQL/firebird/blob/master/src/jrd/constants.h#L449 . But this does not seem to be what the parse.y is doing nor what I see in RDB$TRIGGERS. Can somebody check it? -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/