Re: [Firebird-devel] Backtracking bomb

2019-05-25 Thread Dimitry Sibiryakov
25.05.2019 15:57, Adriano dos Santos Fernandes wrote: As I understand, backtrack happens due to reduce/reduce conflicts and we have 17 of then in the rules. Accepting of PR #189 could reduce the count to 11. Most likely the technique applied there can be used for the rest as well. -- WB

Re: [Firebird-devel] Backtracking bomb

2019-05-25 Thread Adriano dos Santos Fernandes
On 25/05/2019 07:24, Vlad Khorsun wrote: >> >> Do you see any problem to stop backtracking on these places? > >   Usage of YYVALID seems as correct way to fix the problem, but... first > explain > please - why do you mark both rules as valid and why it solves the issue ? > > Note, in test\t2.y ab

Re: [Firebird-devel] Backtracking bomb

2019-05-25 Thread Vlad Khorsun
25.05.2019 2:19, Adriano dos Santos Fernandes wrote: Hi! We always let btyacc nicely handle parser backtracking alone but seems in some cases we should not let it. CORE-6068 is such a case. Parser enters in near-infinite loop allocating and freeing memory trying new paths. Based on the short b