Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-19 Thread livius
There is no need for a new error, but a consistent error scheme should be applied, as already exists. this is what i wanted to say. By "new" - i have thinked, change for old as was chosen for new "big" numerics. BTW: Firebird 4 is not a point release, it is a major release. A point release

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-19 Thread Mark Rotteveel
On 19-6-2018 18:06, livius wrote: it is better to change all already errors to new one in new point release as FB4 is. There is no need for a new error, but a consistent error scheme should be applied, as already exists. BTW: Firebird 4 is not a point release, it is a major release. A point

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-19 Thread livius
Hi, it is better to change all already errors to new one in new point release as FB4 is. As Mark say already, it should be not visible to the user that there is some difference between Numeric(18,2) and numeric(34,34)... All numerics should have same error messages. regards, Karol

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-19 Thread Mark Rotteveel
On 2018-06-18 14:49, Alex Peshkoff via Firebird-devel wrote: On 17.06.2018 13:17, Mark Rotteveel wrote: I don't agree with this ticket getting closed. I raised an objection to the current solution in the comments that I think needs to be addressed. The current solution causes a divergence in

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-19 Thread Mark Rotteveel
On 2018-06-18 15:10, Carlos H. Cantu wrote: I dream about the day that "arithmetic exception, numeric overflow, or string truncation" will be replaced by more specific errors. You may want to look closer at that error: it actually consists of two error codes, which will pretty much narrow it

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-18 Thread Carlos H. Cantu
I dream about the day that "arithmetic exception, numeric overflow, or string truncation" will be replaced by more specific errors. []s Carlos http://www.firebirdnews.org FireBase - http://www.FireBase.com.br APvFd> On 17.06.2018 13:17, Mark Rotteveel wrote: >> I don't agree with this ticket

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-18 Thread Alex Peshkoff via Firebird-devel
On 17.06.2018 13:17, Mark Rotteveel wrote: I don't agree with this ticket getting closed. I raised an objection to the current solution in the comments that I think needs to be addressed. The current solution causes a divergence in errors between decimals(p,s) with p <=18 and 18 < p <=34,

Re: [Firebird-devel] [FB-Tracker] Closed: (CORE-5726) Unclear error message when inserting value exceeding max of dec_fixed decimal

2018-06-17 Thread Mark Rotteveel
I don't agree with this ticket getting closed. I raised an objection to the current solution in the comments that I think needs to be addressed. The current solution causes a divergence in errors between decimals(p,s) with p <=18 and 18 < p <=34, which is confusing and leaks implementation