Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Roman Simakov
2014-09-02 21:31 GMT+04:00 Dmitry Yemanov : > Let me disagree. +1 -- Roman Simakov -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ Firebird-Devel mailing list, web interface at https://l

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dmitry Yemanov
02.09.2014 21:27, Dimitry Sibiryakov wrote: > if (temp.rpb_flags & rpb_delta) > temp.rpb_prior = data; > > doesn't look much better. Let me disagree. Dmitry -- Slashdot TV. Video for Nerds. Stuff that mat

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dimitry Sibiryakov
02.09.2014 19:08, Dmitry Yemanov wrote: > This example violates the project coding style. Oh, yes. But if (temp.rpb_flags & rpb_delta) temp.rpb_prior = data; doesn't look much better. -- WBR, SD. -- Slas

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dmitry Yemanov
02.09.2014 18:35, Dimitry Sibiryakov wrote: > > When was decided that one-line blocks must not be enclosed with parentheses? It didn't change for the past few years: http://www.firebirdsql.org/en/coding-style/ http://geosoft.no/development/cppstyle.html "82. Single statement if-else, for or whil

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dmitry Yemanov
02.09.2014 19:05, Dimitry Sibiryakov wrote: > if (some condition && > some other condition) > hardly recognized line that doing something; This example violates the project coding style. Dmitry -

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread James Starkey
Something to keep in mind is that code is written once, modified a couple of times, and read hundreds of times. Legitibilty is everything from a maintenance perspective. I've written, oh, close to a million lines of code. Two 4gls, four relational database systems, a JVM, a search engine, a temp

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Mark Rotteveel
On Tue, 02 Sep 2014 16:11:43 +0100, Lester Caine wrote: > On 02/09/14 16:00, Mark Rotteveel wrote: >> Braces around single statements would have made this bug less likely. > Have made many bugs less likely ... > It's not 'dangerous' just a little more error prone. > My IDE code completion is set t

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Adriano dos Santos Fernandes
On 02/09/2014 12:05, Dimitry Sibiryakov wrote: > 02.09.2014 17:00, James Starkey wrote: >> Mandatory indentation makes it clear. >No. With tabstop == 4, it is placed exactly under if's condition, > pretending to be > condition's continuation: > > if (some condition && > some oth

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Adriano dos Santos Fernandes
On 02/09/2014 12:00, Mark Rotteveel wrote: > On Tue, 02 Sep 2014 11:43:54 -0300, Adriano dos Santos Fernandes > wrote: >> On 02/09/2014 11:35, Dimitry Sibiryakov wrote: >>>Hi, All. >>> >>>When was decided that one-line blocks must not be enclosed with >>>parentheses? It is a >>> rather

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Lester Caine
On 02/09/14 16:00, Mark Rotteveel wrote: > Braces around single statements would have made this bug less likely. Have made many bugs less likely ... It's not 'dangerous' just a little more error prone. My IDE code completion is set to add the braces on every language. -- Lester Caine - G8HFL

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Mark Rotteveel
On Tue, 02 Sep 2014 17:00:01 +0200, Mark Rotteveel wrote: > On Tue, 02 Sep 2014 11:43:54 -0300, Adriano dos Santos Fernandes > wrote: >> On 02/09/2014 11:35, Dimitry Sibiryakov wrote: >>>Hi, All. >>> >>>When was decided that one-line blocks must not be enclosed with >>>parentheses? It

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dimitry Sibiryakov
02.09.2014 17:00, James Starkey wrote: > Mandatory indentation makes it clear. No. With tabstop == 4, it is placed exactly under if's condition, pretending to be condition's continuation: if (some condition && some other condition) hardly recognized line that doing som

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread James Starkey
September 4, 1984. Why do you say it's dangerous? Mandatory indentation makes it clear. Clear code separated into functional block is more legible if not cluttered with superfluous punctuation. On Tuesday, September 2, 2014, Dimitry Sibiryakov wrote: >Hi, All. > >When was decided that

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Mark Rotteveel
On Tue, 02 Sep 2014 11:43:54 -0300, Adriano dos Santos Fernandes wrote: > On 02/09/2014 11:35, Dimitry Sibiryakov wrote: >>Hi, All. >> >>When was decided that one-line blocks must not be enclosed with >>parentheses? It is a >> rather dangerous style... >> > It's not, it was not and it

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dimitry Sibiryakov
02.09.2014 16:43, Adriano dos Santos Fernandes wrote: > It's not, it was not and it will never be a dangerous style. > > Everything is dangerous if you write code without attention. For me it looks like code obfuscation. May be harmless, but unpleasant. -- WBR, SD. ---

Re: [Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Adriano dos Santos Fernandes
On 02/09/2014 11:35, Dimitry Sibiryakov wrote: >Hi, All. > >When was decided that one-line blocks must not be enclosed with > parentheses? It is a > rather dangerous style... > It's not, it was not and it will never be a dangerous style. Everything is dangerous if you write code without

[Firebird-devel] Coding style: one-line blocks

2014-09-02 Thread Dimitry Sibiryakov
Hi, All. When was decided that one-line blocks must not be enclosed with parentheses? It is a rather dangerous style... -- WBR, SD. -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.o