Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-05 Thread Jiří Činčura
>Done, hope I did it right. Memory is stable in my tests. Great work! -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-05 Thread Vlad Khorsun
05.07.2021 10:17, Jiří Činčura wrote: You may try next build I can confirm the leak does not happen in https://github.com/FirebirdSQL/firebird/actions/runs/999413719 build. Good job! Will all the fixes be ported back to 3.0.8? Done, hope I did it right. Regards, Vlad Firebird-Devel

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-05 Thread Jiří Činčura
>You may try next build I can confirm the leak does not happen in https://github.com/FirebirdSQL/firebird/actions/runs/999413719 build. Good job! Will all the fixes be ported back to 3.0.8? -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ Firebird-Devel mailing list, web interface a

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-03 Thread Mark Rotteveel
On 28-06-2021 21:57, Sam Walker wrote: Please remove from discussion. Thanks You're receiving this email because you're subscribed to the firebird-devel list. If you no longer want to receive emails from this list, you need to unsubscribe. You can do that at https://lists.sourceforge.net/lis

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-03 Thread Vlad Khorsun
02.07.2021 16:43, Vlad Khorsun wrote: 02.07.2021 16:35, Jiří Činčura wrote: Any progress here? It's starting to be bit ridiculous. There's memory leak that's taking down about 15 servers I care about daily and I have to constantly beg for response.   I found and fixed few more places but not

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-02 Thread Vlad Khorsun
02.07.2021 16:35, Jiří Činčura wrote: Any progress here? It's starting to be bit ridiculous. There's memory leak that's taking down about 15 servers I care about daily and I have to constantly beg for response. I found and fixed few more places but not all of them. Still looking... Regards

Re: [Firebird-devel] Memory leak with external engine plugin

2021-07-02 Thread Jiří Činčura
Any progress here? It's starting to be bit ridiculous. There's memory leak that's taking down about 15 servers I care about daily and I have to constantly beg for response. -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ On Tue, Jun 29, 2021, at 14:07, Jiří Činčura wrote: > >Fix is co

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-29 Thread Jiří Činčura
>Fix is committed into v4.0-release. Jiří could you try next build > and report here ? The https://github.com/FirebirdSQL/firebird/actions/runs/982423809 build is correct one, right? Again testing with UDR's `isLeapYear` function. The leak is still there, but seems to be bit smaller: https:

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-29 Thread Vlad Khorsun
21.06.2021 21:55, Adriano dos Santos Fernandes wrote: I'm testing with the example function: create function sum_args ( n1 integer, n2 integer, n3 integer ) returns integer external name 'udrcpp_example!sum_args' engine udr; select sum_args(1, 2, 3) from rdb$database w

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-29 Thread Jiří Činčura
When calling, from same script, PSQL function (instead of UDR): https://snipboard.io/Kg6w54.jpg. Stable memory consumption. -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-28 Thread Sam Walker
Please remove from discussion. Thanks On Mon, Jun 28, 2021 at 3:18 AM Jiří Činčura wrote: > Any progress on this? Should I create issue for it? > > -- > Mgr. Jiří Činčura > https://www.tabsoverspaces.com/ > > > > Firebird-Devel mailing list, web interface at > https://lists.sourceforge.net/lists

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-28 Thread Adriano dos Santos Fernandes
On 28/06/2021 04:17, Jiří Činčura wrote: > Any progress on this? Should I create issue for it? > Did you not see the leak when testing various simultaneous connections without use an external engine? For example, referencing a PSQL function? Adriano Firebird-Devel mailing list, web interface

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-28 Thread Jiří Činčura
Any progress on this? Should I create issue for it? -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-22 Thread Jiří Činčura
Here's the results. Looks like it's leaking even with UDR. I used Firebird-4.0.0.2496-1-x64-pdb. Only initialized security database. Nothing else. MemoryDemo plugin (https://snipboard.io/AmZ5I7.jpg): Function `isLeapYear` from `udr_compat` (https://snipboard.io/yIDAMZ.jpg): Either the [1] or [2

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-22 Thread Dimitry Sibiryakov
22.06.2021 14:07, Jiří Činčura wrote: Can I do that? Just repeat your tests with some "legacy UDR" functions provided with vanilla Firebird installation. -- WBR, SD. Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-22 Thread Jiří Činčura
> It must be first understand if this is really the problem. Can I do that? Or can I help you in any way? I have a FB4 vanilla folder, the compiled plugin and simple script. I can send it to you and you can play with that, if you want. > Your memory consumption graph was done in FB 3 or 4? FB

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-22 Thread Adriano dos Santos Fernandes
On 22/06/2021 03:00, Jiří Činčura wrote: >> I cannot say the same is done with the CRT you are using, so you may >> have others memory leaks. > > Is this something I can test? And potentially do something about it? In real > world other pieces might be using that. :( > It must be first underst

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-22 Thread Jiří Činčura
> UDR engine uses Firebird memory pool which is destroyed when the plugin > is unloaded. BTW what exactly you mean by unloaded? You mean IExternalEngineImpl::release being called? Or something like FreeLibrary? -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ Firebird-Devel mailing list,

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-21 Thread Jiří Činčura
> I cannot say the same is done with the CRT you are using, so you may > have others memory leaks. Is this something I can test? And potentially do something about it? In real world other pieces might be using that. :( > Would also be good if you put something in your function to really known >

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-21 Thread Adriano dos Santos Fernandes
On 21/06/2021 16:57, Jiří Činčura wrote: > What is this gonna tell me? > UDR engine uses Firebird memory pool which is destroyed when the plugin is unloaded. I cannot say the same is done with the CRT you are using, so you may have others memory leaks. Would also be good if you put something in

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-21 Thread Jiří Činčura
What is this gonna tell me? -- Mgr. Jiří Činčura https://www.tabsoverspaces.com/ On Mon, Jun 21, 2021, at 20:55, Adriano dos Santos Fernandes wrote: > On 21/06/2021 15:17, Jiří Činčura wrote: > > Hi *, > > > > I think I have an example of memory leaking when using external engine > > plugin (3

Re: [Firebird-devel] Memory leak with external engine plugin

2021-06-21 Thread Adriano dos Santos Fernandes
On 21/06/2021 15:17, Jiří Činčura wrote: > Hi *, > > I think I have an example of memory leaking when using external engine plugin > (3.0.7, 4.0.0). > > Here's as simple implementation as I can make it (sorry for probably > non-idiomatic C++ code): > https://gist.github.com/cincuranet/aa207081

[Firebird-devel] Memory leak with external engine plugin

2021-06-21 Thread Jiří Činčura
Hi *, I think I have an example of memory leaking when using external engine plugin (3.0.7, 4.0.0). Here's as simple implementation as I can make it (sorry for probably non-idiomatic C++ code): https://gist.github.com/cincuranet/aa207081dc0d44e5d06c1a4890019307 . Then I create a dummy functio