Re: [Firebird-devel] PSQL profiler

2020-09-29 Thread Adriano dos Santos Fernandes
On 29/09/2020 13:43, Dmitry Yemanov wrote: > 28.09.2020 20:44, Adriano dos Santos Fernandes wrote: >> >> I have thought on that possibility since the start and the conflict >> points I see are: >> - Name of RDB$PROFILE_STATS - perhaps RDB$PROFILE_PSQL? > > Maybe we may leave it as is. And add RDB$P

Re: [Firebird-devel] PSQL profiler

2020-09-29 Thread Dmitry Yemanov
28.09.2020 20:44, Adriano dos Santos Fernandes wrote: I have thought on that possibility since the start and the conflict points I see are: - Name of RDB$PROFILE_STATS - perhaps RDB$PROFILE_PSQL? Maybe we may leave it as is. And add RDB$PROFILE_CURSOR_STATS. The question is how they should be

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Adriano dos Santos Fernandes
On 28/09/2020 14:26, Dmitry Yemanov wrote: > 28.09.2020 13:27, Adriano dos Santos Fernandes wrote: > >> I would like something about cursors too and I think in the future it >> can be added. > > I believe this should be a top-priority thing. I doubt many users > implement heavy logic in PSQL withou

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Dmitry Yemanov
28.09.2020 13:27, Adriano dos Santos Fernandes wrote: I would like something about cursors too and I think in the future it can be added. I believe this should be a top-priority thing. I doubt many users implement heavy logic in PSQL without queries, so per-statement stats is mostly usable t

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Adriano dos Santos Fernandes
On 28/09/2020 07:31, Dimitry Sibiryakov wrote: > 28.09.2020 02:11, Adriano dos Santos Fernandes wrote: >> Here is link to pull request, starting with the README describing the >> feature > >   What is performance impact of this feature on attachments that do > not profiling? > If profiler was neve

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Dmitry Yemanov
28.09.2020 03:11, Adriano dos Santos Fernandes wrote: I have a doubt about permissions. If user can call procedure P1 but cannot himself call procedure P2, but procedure P1 can call P2, if profiler should not collect data from P2. Current it does. Given that user can see other statistics (pag

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Dimitry Sibiryakov
28.09.2020 02:11, Adriano dos Santos Fernandes wrote: Here is link to pull request, starting with the README describing the feature What is performance impact of this feature on attachments that do not profiling? -- WBR, SD. Firebird-Devel mailing list, web interface at https://lists.s

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Adriano dos Santos Fernandes
On 28/09/2020 03:41, Simonov Denis via Firebird-devel wrote: > Adriano dos Santos Fernandes писал(а) в своём > письме Mon, 28 Sep 2020 03:11:05 +0300: > >> Hi! >> >> Here is link to pull request, starting with the README describing the >> feature: >> >> https://github.com/FirebirdSQL/firebird/pull

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Adriano dos Santos Fernandes
On 28/09/2020 07:22, Dmitry Yemanov wrote: > 28.09.2020 09:41, Simonov Denis via Firebird-devel wrote: > >> 2. The minimum and maximum time is certainly interesting, but it >> would be nice to display the average execution time. > > RDB$ACCUMULATED_TIME / RDB$COUNTER > Yes and I wanted the average

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Dmitry Yemanov
28.09.2020 09:41, Simonov Denis via Firebird-devel wrote: 2. The minimum and maximum time is certainly interesting, but it would be nice to display the average execution time. RDB$ACCUMULATED_TIME / RDB$COUNTER Dmitry Firebird-Devel mailing list, web interface at https://lists.sourceforg

Re: [Firebird-devel] PSQL profiler

2020-09-28 Thread Dmitry Yemanov
28.09.2020 09:41, Simonov Denis via Firebird-devel wrote: 1. Why is statistics limited to procedure / function / trigger and block only? But what about queries and cursors inside blocks. Their execution times are much more interesting. RDB$PROFILE_STATS contains statement ID and RDB$LINE/RDB$

Re: [Firebird-devel] PSQL profiler

2020-09-27 Thread Simonov Denis via Firebird-devel
Adriano dos Santos Fernandes писал(а) в своём письме Mon, 28 Sep 2020 03:11:05 +0300: Hi! Here is link to pull request, starting with the README describing the feature: https://github.com/FirebirdSQL/firebird/pull/285/files I have a few questions. 1. Why is statistics limited to proced

Re: [Firebird-devel] PSQL profiler

2020-09-27 Thread Leyne, Sean
> Here is link to pull request, starting with the README describing the > feature: > > https://github.com/FirebirdSQL/firebird/pull/285/files > > I have a doubt about permissions. > > If user can call procedure P1 but cannot himself call procedure P2, but > procedure > P1 can call P2, if pro

[Firebird-devel] PSQL profiler

2020-09-27 Thread Adriano dos Santos Fernandes
Hi! Here is link to pull request, starting with the README describing the feature: https://github.com/FirebirdSQL/firebird/pull/285/files I have a doubt about permissions. If user can call procedure P1 but cannot himself call procedure P2, but procedure P1 can call P2, if profiler should not co