Re: [Firebird-devel] Trace session and choice of events

2021-08-17 Thread Dimitry Sibiryakov
17.08.2021 12:23, Vlad Khorsun wrote: It requires to move trace_needs() from ITraceFactory to ITracePlugin, btw. In the name of good design - yes, but current "trace_needs() is always called after corresponding trace_create() in the same critical section" is also working. -- WBR, SD. F

Re: [Firebird-devel] Trace session and choice of events

2021-08-17 Thread Vlad Khorsun
13.08.2021 19:02, Dimitry Sibiryakov wrote:   Hello All,   As I see in TraceManager code every trace session is receiving not only events it is subscribed for with trace_needs() but also everything that previous sessions were subscribed for.   For me it looks like a rather strange design. W

[Firebird-devel] Trace session and choice of events

2021-08-13 Thread Dimitry Sibiryakov
Hello All, As I see in TraceManager code every trace session is receiving not only events it is subscribed for with trace_needs() but also everything that previous sessions were subscribed for. For me it looks like a rather strange design. What is the purpose of that? -- WBR, SD. Fi