Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread Jiri Cincura
sasha wrote: >> Isn't ReSharper paid? > > It's paid, but it has 30 days trial. But it's trial. Not for working. >> I don't think, that provider's code is ugly. I think, that it's very >> good readable and "pretty printing". > > It's not ugly, but it can be better. I can send you screenshots fr

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread sasha
> Isn't ReSharper paid? It's paid, but it has 30 days trial. > I don't think, that provider's code is ugly. I think, that it's very > good readable and "pretty printing". It's not ugly, but it can be better. I can send you screenshots from my VS if you want... --

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread Jiri Cincura
sasha wrote: > Yet one. Do you know about such wonderful VS plugin as resharper? If no, > you can try it and I'm sure you will like it. > > http://www.jetbrains.com/resharper/ > > this plugin can help keep codes much more clear and found some mistakes > in code. When i opened providers sources

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread sasha
Yet one. Do you know about such wonderful VS plugin as resharper? If no, you can try it and I'm sure you will like it. http://www.jetbrains.com/resharper/ this plugin can help keep codes much more clear and found some mistakes in code. When i opened providers sources then with resharper i see m

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread Jiri Cincura
Jiri Cincura wrote: > Carlsos. Sorry Carlos. Damn typo. :D -- Jiri {x2} Cincura http://blog.vyvojar.cz/jirka/ | http://www.ID3renamer.com - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE ver

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread Jiri Cincura
sasha wrote: > Common advice. Carlsos. What about if I review current code for checking buffer length too? Then we can create something with FB2.1 improvements. :) -- Jiri {x2} Cincura http://blog.vyvojar.cz/jirka/ | http://www.ID3renamer.com ---

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-27 Thread sasha
> BTW if you talked with Vlad. Checking array length is a common advice or > related to FB 2.1? Common advice. - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and ta

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-26 Thread Jiri Cincura
sasha wrote: > Hi! I've tried to use provider with FB 2.1 and there were a broblems > with new FB protocol: > > http://tracker.firebirdsql.org/browse/CORE-1218 > > But vlad said that provider should not only check isc_info_end, but > array length too. So i propose to make some changes in Statem

Re: [Firebird-net-provider] Some minor improvement in provider's code

2007-04-26 Thread Jiri Cincura
Hi, nice job. But shouldn't be the ProcessRecordsAffectedBuffer method be improved too (and some others on other place (i.e. ParseQueryInfo from FbService, etc.), that are checking IscCodes.isc_info_end)? So I suppose to check (and improve) these methods and then test the changes. If Carlos ha

[Firebird-net-provider] Some minor improvement in provider's code

2007-04-26 Thread sasha
Hi! I've tried to use provider with FB 2.1 and there were a broblems with new FB protocol: http://tracker.firebirdsql.org/browse/CORE-1218 But vlad said that provider should not only check isc_info_end, but array length too. So i propose to make some changes in StatementBase.cs in method Par