Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Геннадий Забула
The name '{name}' is longer than Firebird's {LengthLimit} characters limit for objects names. On 9 December 2015 at 15:42, Jiří Činčura wrote: > Be my guest: > https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/commit/4d8d1b8a5d72b6304e8d15af36542f72a9b5da8c#diff-02c77ebea06976e32e7ce3

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Jiří Činčura
Be my guest: https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/commit/4d8d1b8a5d72b6304e8d15af36542f72a9b5da8c#diff-02c77ebea06976e32e7ce3b42bca24c9R641 . I'm open to rewording it, as I'm bit flat on creativity today. :D -- Mgr. Jiří Činčura Independent IT Specialist

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Геннадий Забула
I think it should be ArgumentOutOfRange On 9 December 2015 at 15:13, Jiří Činčura wrote: > On Wed, Dec 9, 2015, at 13:43, Jiří Činčura wrote: >> On Sun, Dec 6, 2015, at 18:29, Геннадий Забула wrote: >> > I think the earlier it will be thrown the better. Also, in exception >> > message you can inc

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Jiří Činčura
On Wed, Dec 9, 2015, at 13:43, Jiří Činčura wrote: > On Sun, Dec 6, 2015, at 18:29, Геннадий Забула wrote: > > I think the earlier it will be thrown the better. Also, in exception > > message you can include text or/and link about workaround of this FB > > limitation. It will be a good convenience

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Jiří Činčura
On Sun, Dec 6, 2015, at 18:29, Геннадий Забула wrote: > I think the earlier it will be thrown the better. Also, in exception > message you can include text or/and link about workaround of this FB > limitation. It will be a good convenience for library users. As I don't have any opinion on that I'l

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-09 Thread Jiří Činčura
> Will this PR get merged: > https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/pull/43 > ? Yes. -- Mgr. Jiří Činčura Independent IT Specialist -- ___ Firebird-net-

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-06 Thread Геннадий Забула
One more question. Will this PR get merged: https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/pull/43 ? On 6 December 2015 at 19:29, Геннадий Забула wrote: >> Do you think it should throw exception? I would rather let that for >> Firebird. Somebody might tweak the script or something

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-06 Thread Геннадий Забула
> Do you think it should throw exception? I would rather let that for > Firebird. Somebody might tweak the script or something like that. > I know you proposed hashing the name, but that's not reasonable general > solution. The database would look gibberish for outside view. Nobody > would know wh

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-12-05 Thread Jiří Činčura
> 1. readonly IFbMigrationSqlGeneratorBehavior _behavior; > Is used only in migration operations DropColumn/AlterColumn, not used > in AddColumn. The AddColumnOperation calls Generate method for ColumnModel and this method handles the identity stuff. Or do you mean something else? > 2. We have ad

Re: [Firebird-net-provider] 4.9.0 beta 1 release

2015-11-15 Thread Геннадий Забула
Here is my comments about Migration: 1. readonly IFbMigrationSqlGeneratorBehavior _behavior; Is used only in migration operations DropColumn/AlterColumn, not used in AddColumn. 2. We have additional implementation of Check in (0,1) for boolean fields like implemented in SsdlToSql.cs 3. CreateItemNa