[Firebird-net-provider] [FB-Tracker] Created: (DNET-253) class FbPoolManager OnEmptyPool issue

2009-07-04 Thread Jiri Cincura (JIRA)
 class FbPoolManager OnEmptyPool issue
--

 Key: DNET-253
 URL: http://tracker.firebirdsql.org/browse/DNET-253
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class FbPoolManager 
private void OnEmptyPool(object sender, EventArgs e) 
{ 
lock (this.Pools.SyncRoot) 
{ 
int hashCode = (int)sender; 
 
the last line is wrong since sender is a connection string 
should be 
int hashCode = sender.GetHashCode();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


[Firebird-net-provider] [FB-Tracker] Created: (DNET-251) FbConnectionInternal public FbTransaction BeginTransaction methods issue

2009-07-04 Thread Jiri Cincura (JIRA)
FbConnectionInternal   public FbTransaction BeginTransaction methods issue
--

 Key: DNET-251
 URL: http://tracker.firebirdsql.org/browse/DNET-251
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class FbConnectionInternal 
public FbTransaction BeginTransaction methods 
as I think, if this.activeTransaction.BeginTransaction() call raises exception 
then activeTransaction should be disposed and nulled. if not - next time it 
will cause HasActiveTransaction to return true and InvalidOperationException("A 
transaction is currently active. Parallel transactions are not supported.") 
will be thrown. InvalidOperationException is not FbException and complecates 
exception handling in outer code. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


[Firebird-net-provider] [FB-Tracker] Created: (DNET-252) class IscException Message property Why is it NEW instead of OVERRIDE?

2009-07-04 Thread Jiri Cincura (JIRA)
class IscException   Message property   Why is it NEW instead of OVERRIDE?
--

 Key: DNET-252
 URL: http://tracker.firebirdsql.org/browse/DNET-252
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class IscException 
Message property 
Why is it NEW instead of OVERRIDE?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


[Firebird-net-provider] [FB-Tracker] Created: (DNET-250) FbBatchExecution in method Execute() events improvements

2009-07-04 Thread Jiri Cincura (JIRA)
FbBatchExecution   in method Execute() events improvements
--

 Key: DNET-250
 URL: http://tracker.firebirdsql.org/browse/DNET-250
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class FbBatchExecution 
in method Execute() sometimes for raising events used constructions like this 
  this.OnCommandExecuting(null); 
... 
  this.OnCommandExecuted(null,... 
Events raised by such calls are useless. It is not possible to know neither 
statement type nor statement text. Why not to pass sqlCommand?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


[Firebird-net-provider] [FB-Tracker] Created: (DNET-249) FbCommand method private void UpdateParameterValues() issue

2009-07-04 Thread Jiri Cincura (JIRA)
FbCommand   method private void UpdateParameterValues()   issue
---

 Key: DNET-249
 URL: http://tracker.firebirdsql.org/browse/DNET-249
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class FbCommand 
method private void UpdateParameterValues() 
issue occurs when setting parameter value as byte[] for field with database 
type BLOB SUBTYPE TEXT 
current source code accepts only string value 
as a suggestion: replace 

blob.Write((string)this.Parameters[index].Value); 
with something like this 
var valueType = 
this.Parameters[index].Value.GetType(); 
if (valueType.IsArray && 
valueType.GetElementType() == typeof(byte)) 
{ 

blob.Write((byte[])this.Parameters[index].Value); 
} 
else 

blob.Write((string)this.Parameters[index].Value);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider


[Firebird-net-provider] [FB-Tracker] Created: (DNET-248) DatabaseParameterBuffer has a bug

2009-07-04 Thread Jiri Cincura (JIRA)
DatabaseParameterBuffer has a bug
-

 Key: DNET-248
 URL: http://tracker.firebirdsql.org/browse/DNET-248
 Project: .NET Data provider
  Issue Type: Sub-task
  Components: ADO.NET Provider
Reporter: Jiri Cincura
Assignee: Jiri Cincura


class DatabaseParameterBuffer has a bug in method 
public void Append(int type, byte value) 
{ 
this.WriteByte(type); 
this.WriteByte(1); 
this.Write(value); //this is a bug 
} 
this method writes 4 bytes instead of 3 because the base class ParameterBuffer 
has no Write(byte) overload so Write(short) is used

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://tracker.firebirdsql.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira



--
___
Firebird-net-provider mailing list
Firebird-net-provider@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/firebird-net-provider