Re: [Flac-dev] Is FLAC__stream_decoder_seek_absolute working for OggFlac?

2007-09-11 Thread Josh Coalson
--- Erik de Castro Lopo [EMAIL PROTECTED] wrote: Josh Coalson wrote: --- Erik de Castro Lopo [EMAIL PROTECTED] wrote: Hi all, Is seeking working for OggFlac files? I keep on getting a FLAC__STREAM_DECODER_SEEK_ERROR. yes, it should work fine. in

Re: [Flac-dev] Is FLAC__stream_decoder_seek_absolute working for OggFlac?

2007-09-11 Thread Erik de Castro Lopo
Josh Coalson wrote: The test file is here: http://www.mega-nerd.com/tmp/flac_char.ogg yep, this is definitely a bug, thanks for the test case. requires a tiny fix to the ogg seek algorithm which I will check in tonight. Oh cool. I was wondering what happened to that issue. Erik

Re: [Flac-dev] Is FLAC__stream_decoder_seek_absolute working for OggFlac?

2007-09-11 Thread Josh Coalson
--- Erik de Castro Lopo [EMAIL PROTECTED] wrote: Josh Coalson wrote: The test file is here: http://www.mega-nerd.com/tmp/flac_char.ogg yep, this is definitely a bug, thanks for the test case. requires a tiny fix to the ogg seek algorithm which I will check in tonight.

Re: [Flac-dev] include/share/alloc.h

2007-09-11 Thread Josh Coalson
--- Erik de Castro Lopo [EMAIL PROTECTED] wrote: Josh, I noticed the recent addition of the above file. In that file you have things like: static void *safe_malloc_(size_t size) { /* malloc(0) is undefined; FLAC src convention is to always allocate */

Re: [Flac-dev] include/share/alloc.h

2007-09-11 Thread Erik de Castro Lopo
Josh Coalson wrote: yes. I would use inline except I thought it is only since C99 (not available in C89), so I'm planning to do the same odious hackery that's everywhere else. Well it is the year 2007 and I for one reckon its time fully embrace a standard that is 8 years old :-). It does