Rafael Velasquez wrote:
Hello,
I still having problem for the compilation.
i do : make -f Makefile.lite
Don't do that.
Do:
./configure
make
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
Cristian Rodríguez wrote:
strlen() returns the length excluding the terminating null byte..then
an string of len 4 will be off-by-one in application_id[4];
GCC 4.7 detects this bug.
Ah nice!
diff --git a/src/metaflac/options.c b/src/metaflac/options.c
index eb3498d..2cb0959 100644
---
---
src/libFLAC/bitwriter.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/src/libFLAC/bitwriter.c b/src/libFLAC/bitwriter.c
index 651440d..7da4b15 100644
--- a/src/libFLAC/bitwriter.c
+++ b/src/libFLAC/bitwriter.c
@@ -43,12 +43,11 @@
/*
Agreed. I was going to suggest memcpy() or something equivalent,
because the FLAC structure is not literally a C string, but rather a
32-bit field that may or may not have a terminating NULL. Erik's
code should work correctly in all cases.
On Apr 5, 2012, at 04:02, Erik de Castro Lopo
---
configure.ac |7 +
src/libFLAC/bitreader.c | 12 ++---
src/libFLAC/bitwriter.c |8 ++
src/libFLAC/fixed.c | 18 +
src/libFLAC/format.c |8 ++
El 05/04/12 18:30, Brian Willoughby escribió:
Agreed. I was going to suggest memcpy() or something equivalent,
because the FLAC structure is not literally a C string, but rather a
32-bit field that may or may not have a terminating NULL. Erik's
code should work correctly in all cases.
Yep,
Cristian Rodríguez wrote:
Applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
Cristian Rodríguez wrote:
---
Applied. Thanks.
I also took the liberty of adding a Xiph.org copyright header to the
new macros.h file.
Cheers,
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
