[flac-dev] [PATCH] Add missing functions to SeekTable class

2012-05-05 Thread Bastiaan Timmer
The attached patch adds the missing FLAC__metadata_object_seektable_*() functions from FLAC's metadata object methods (FLAC/metadata.h) to FLAC++'s SeekTable class. Of the 11 functions in the C API, only 4 are currently in the C++ API, this patch adds the missing 7. If this patch is ok,

[flac-dev] [PATCH] Optionally, allow distros to use openssl for MD5 verification

2012-05-05 Thread Cristian Rodríguez
This has the advantage of being more efficient than the included routines and allows distros to centralize crypto mainteniance on a few libraries. --- configure.ac |4 +- m4/ax_check_openssl.m4| 124 +

Re: [flac-dev] [PATCH] Optionally, allow distros to use openssl for MD5 verification

2012-05-05 Thread Eric Wong
Cristian Rodríguez crrodrig...@opensuse.org wrote: +#if defined(HAVE_OPENSSL) +/* decoder-private_-computed_md5sum is NULL when decoder-private_-do_md5_checking == false +* that causes assertion failure crash in openSSL. +*/ +if(decoder-private_-do_md5_checking) { +

Re: [flac-dev] [PATCH] Optionally, allow distros to use openssl for MD5 verification

2012-05-05 Thread Erik de Castro Lopo
Eric Wong wrote: Can you do this without sprinkling #ifdefs all over the place? +1 Mixing #ifdefs and normal C control structures make code hard to read/maintain. This is *especially* true for folks who aren't regular contributors to flac, myself included. Very much agree. Erik --