Martin Leese wrote:
Would not a /* Do not remove */ comment be
sufficient (and much less effort)?
Less effort, but also less reliable.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
On Wed, Jul 02, 2014 at 10:18:58PM +0200, Martijn van Beurden wrote:
http://www.audiograaf.nl/misc_stuff/FLAC-performance-test-Linux-GCC-4.8.pdf
http://www.audiograaf.nl/misc_stuff/FLAC-performance-test-Wine-MSVC-2013.pdf
For the GCC 4.8 results, there is a*very nice 60% to 70% speed
lvqcl wrote:
1)
lpc.c, FLAC__lpc_quantize_coefficients():
snip
2)
There's the following code in stream_decoder.c:
Like you, I don't see a lot of value in these. I think I'll decline
these.
Cheers,
Erik
--
--
Erik de
On Thu, Jul 03, 2014 at 04:21:59PM +0400, lvqcl wrote:
Erik de Castro Lopo wrote:
There's the following code in stream_decoder.c:
Like you, I don't see a lot of value in these. I think I'll decline
these.
FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4
and if
lvqcl wrote:
FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4
and if it's greater then it jumps to FLAC__lpc_restore_signal_asm_ia32.
I wonder why the same wasn't done for PPC/Altivec: why libFLAC compares
'order' and 8 in C code and not in asm.
...more about PPC ASM:
lvqcl wrote:
Not quite ;) You missed the fact that this .vcproj file contains 2 different
settings: one for Debug build and another for Release build.
The patch that fixes Release build is attached.
Thanks! I should have probably left that to you so you could test it.
Cheers,
Erik
--
