[flac-dev] [PATCH] Support 64-bit brword/bwword

2015-12-31 Thread lvqcl
Here is the patch that allows to set FLAC__BYTES_PER_WORD to 8. This is disabled by default though. To test FLAC__BYTES_PER_WORD==8: open src/libFLAC/bitreader.c, src/libFLAC/bitwriter.c, src/test_libFLAC/bitwriter.c and change '#if 1' to '#if 0'. The value of FLAC__BYTES_PER_WORD must be the sa

Re: [flac-dev] FLAC__BYTES_PER_WORD==8 test results

2015-12-31 Thread Erik de Castro Lopo
Cristian Adam wrote: > > On Windows x64 sizeof(long) is 4, but sizeof(ptrdiff_t) is 8. > > Any reasons for not using sizeof(ptrdiff_t)? Because of x32 Linux which is the x86_64 registers but with 32 bit pointers. 32 bit pointers means sizeof(ptrdiff_t) is probably 4. Erik -- -

Re: [flac-dev] FLAC__BYTES_PER_WORD==8 test results

2015-12-31 Thread Cristian Adam
On 31-Dec-15 09:00, Erik de Castro Lopo wrote: Brian Willoughby wrote: What's wrong with something incredible simple, like: #define FLAC__BYTES_PER_WORD (sizeof(int)) The fact that it actually is not correct. We want to determine the size in bits of the CPU registers. Here's what I know:

Re: [flac-dev] [PATCH 4] for test_libFLAC/bitwriter.c

2015-12-31 Thread Erik de Castro Lopo
lvqcl wrote: > 1) The definition of FLAC__BitWriter was updated with the > current text from /libFLAC/bitwriter.c (the text in comments was changed). > And the definition of TOTAL_BITS was made closer to the code from > /libFLAC/bitwriter.c. > > > 2) The values for 'words' and 'bits' values now

Re: [flac-dev] [PATCH 3] for bitwriter.c

2015-12-31 Thread Erik de Castro Lopo
lvqcl wrote: > 1) Added assert > FLAC__ASSERT((bits == 32) || (val>>bits == 0)) > It was inspired by https://sourceforge.net/p/flac/bugs/351/ > Such situation should be detected at least. Applied. Thanks. Erik -- -- Erik d

Re: [flac-dev] FLAC__BYTES_PER_WORD==8 test results

2015-12-31 Thread Erik de Castro Lopo
Brian Willoughby wrote: > What's wrong with something incredible simple, like: > > #define FLAC__BYTES_PER_WORD (sizeof(int)) The fact that it actually is not correct. We want to determine the size in bits of the CPU registers. Here's what I know: sizeof(int) sizeof (