Re: [Flac-dev] better seeking

2006-11-07 Thread Miroslav Lichvar
On Tue, Nov 07, 2006 at 08:43:37AM -0800, Josh Coalson wrote: > > I see you have changed the channels and bps setting, this doesn't > > work > > when the decoder hasn't decoded a frame. There should be a fallback > > for this case. > > ah, yes... this was a question I was going to ask you about >

Re: [Flac-dev] better seeking

2006-11-07 Thread Josh Coalson
--- Miroslav Lichvar <[EMAIL PROTECTED]> wrote: > On Mon, Nov 06, 2006 at 08:50:44AM -0800, Josh Coalson wrote: > > ok, tried it out... passes test/test_seeking.sh and my > > "xmms twitch" test, checked in to CVS. thanks! > > Thanks! > > I see you have changed the channels and bps setting, this

Re: [Flac-dev] better seeking

2006-11-07 Thread Miroslav Lichvar
On Mon, Nov 06, 2006 at 08:50:44AM -0800, Josh Coalson wrote: > ok, tried it out... passes test/test_seeking.sh and my > "xmms twitch" test, checked in to CVS. thanks! Thanks! I see you have changed the channels and bps setting, this doesn't work when the decoder hasn't decoded a frame. There sh

Re: [Flac-dev] better seeking

2006-11-06 Thread Josh Coalson
ok, tried it out... passes test/test_seeking.sh and my "xmms twitch" test, checked in to CVS. thanks! Josh --- Miroslav Lichvar <[EMAIL PROTECTED]> wrote: > On Fri, Nov 03, 2006 at 10:01:42AM +0100, Miroslav Lichvar wrote: > > Thanks. Sending latest version of the patch. Now it can seek in > f

Re: [Flac-dev] better seeking

2006-11-03 Thread Miroslav Lichvar
On Fri, Nov 03, 2006 at 10:01:42AM +0100, Miroslav Lichvar wrote: > Thanks. Sending latest version of the patch. Now it can seek in files > that have large id3 tag (or any random data) at the end and it won't loop on > streams with shuffled frames. One small patch on top of that and it's bug free.

Re: [Flac-dev] better seeking

2006-11-03 Thread Miroslav Lichvar
On Mon, Oct 30, 2006 at 11:13:25AM -0800, Josh Coalson wrote: > my apologies for not doing this before Miroslav... I will definitely > integrate it this time. Thanks. Sending latest version of the patch. Now it can seek in files that have large id3 tag (or any random data) at the end and it won't

Re: [Flac-dev] better seeking

2006-10-30 Thread Josh Coalson
my apologies for not doing this before Miroslav... I will definitely integrate it this time. Josh --- Miroslav Lichvar <[EMAIL PROTECTED]> wrote: > Ok, the patch from 2003 about improving seeking still didn't make it > to CVS, so here is another try. > > I made some benchmarking with the test_

Re: [Flac-dev] better seeking

2006-10-28 Thread Avuton Olrich
On 10/28/06, Miroslav Lichvar <[EMAIL PROTECTED]> wrote: Ok, the patch from 2003 about improving seeking still didn't make it to CVS, so here is another try. Both mails from you were in my SPAM (gmail) box, hope that's not impeding this patch. -- avuton -- Anyone who quotes me in their sig is a

Re: [Flac-dev] better seeking

2006-10-28 Thread Miroslav Lichvar
Ok, the patch from 2003 about improving seeking still didn't make it to CVS, so here is another try. I made some benchmarking with the test_seeking utility from flac sources to show how bad the current seeking is, especially without seektable. Track used for the experiment had about 50 minutes.