[flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

2012-05-07 Thread Bastiaan Timmer
Attached is a patch that adds 5 missing FLAC__metadata_object_vorbiscomment_* functions to the VorbisComment class. In my previous message I stated 8 functions were missing, but on closer inspection, 3 of those belong in the VorbisComment::Entry class, and 2 of them already have equivalent

Re: [flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

2012-05-07 Thread Cristian Rodríguez
El 07/05/12 17:02, Bastiaan Timmer escribió: Attached is a patch that adds 5 missing FLAC__metadata_object_vorbiscomment_* functions to the VorbisComment class. In my previous message I stated 8 functions were missing, but on closer inspection, 3 of those belong in the VorbisComment::Entry

Re: [flac-dev] [PATCH] Add missing functions to VorbisComment class + a few other things

2012-05-07 Thread Bastiaan Timmer
While you are at it, can you check/fix the following warning ? metadata.cpp:812:98: warning: narrowing conversion of 'strlen(((const char*)string))' from 'size_t {aka long unsigned int}' to 'FLAC__uint32 {aka unsigned int}' inside { } is ill-formed in C++11 [-Wnarrowing] Thanks !