Janne Hyvärinen wrote:
> Solution file still contained the removed in_flac project causing
> unnecessary errors on load.
Sorry, that patch doesn't apply to what's currently in git. I could
try and edit the FLAC.sln file by hand, but I have no way to test if
it still works. Please check and resub
Janne Hyvärinen wrote:
> Here's a patch that fixes WAVE64 format handling. GUID had one word
> incorrectly in little endian order.
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
_
Erik de Castro Lopo wrote:
> Hi all,
>
> There are a bunch of sprintf calls in the FLAC code base and I'd like
> to replace them with calls to snprintf but I know that can cause
> problems with at least some versions of Visual Studio.
>
> Whats the current state of play in this regard?
Does MSV
Erik de Castro Lopo wrote:
> Does MSVS have ?
Hmm, seems to:
http://msdn.microsoft.com/en-us/library/kb57fad8%28v=vs.80%29.aspx
Hope it works as expected.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
_
JonY wrote:
> On 3/17/2013 10:33, Janne Hyvärinen wrote:
> > Here's a patch that makes MSVC compiled flac.exe able to use wildcards
> > and encode/decode files with Unicode characters in names. It may not be
> > the prettiest code but it fulfills its primary purpose.
> > I tried to alter FLAC code
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17.03.2013 06:33, Janne Hyvärinen wrote:
> Here's a patch that makes MSVC compiled flac.exe able to use
> wildcards and encode/decode files with Unicode characters in names.
> It may not be the prettiest code but it fulfills its primary
> purpose. I
Janne Hyvärinen wrote:
> Patch for snprintf stuff.
Applied and pushed.
Thats it for me tonight.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
fla
On 3/17/2013 18:37, Erik de Castro Lopo wrote:
> JonY wrote:
>
>> On 3/17/2013 10:33, Janne Hyvärinen wrote:
>>> Here's a patch that makes MSVC compiled flac.exe able to use wildcards
>>> and encode/decode files with Unicode characters in names. It may not be
>>> the prettiest code but it fulfills
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17.03.2013 18:55, JonY wrote:
> On 3/17/2013 18:37, Erik de Castro Lopo wrote:
>> JonY wrote:
>>
>>> On 3/17/2013 10:33, Janne Hyvärinen wrote:
Here's a patch that makes MSVC compiled flac.exe able to use
wildcards and encode/decode files
Janne Hyvärinen wrote:
> One more set of MSVC project updates. Changed ogg_static.lib to
> libogg_static.lib as that's the name latest version uses. Removed MSVC
> 6.0 related parts from README and tweaked info there to be more
> up-to-date. Also changed nasmw.exe into nasm.exe as nasmw.exe has
On 3/17/2013 23:01, LRN wrote:
>> All those ifdefs will at least be confined rather than spread out
>> through the code.
> I did it plibc-style:
>
> in compat.h:
> #if defined(_WIN32)
> #define FOPEN grabbag__fopen_utf8_wrapper
> #else
> #define FOPEN fopen
> #endif
>
> in grabbag:
> #if defined
JonY wrote:
> On 3/17/2013 23:01, LRN wrote:
> >> All those ifdefs will at least be confined rather than spread out
> >> through the code.
> > I did it plibc-style:
> >
> > in compat.h:
> > #if defined(_WIN32)
> > #define FOPEN grabbag__fopen_utf8_wrapper
> > #else
> > #define FOPEN fopen
> > #e
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 18.03.2013 02:10, JonY wrote:
> On 3/17/2013 23:01, LRN wrote:
>>> All those ifdefs will at least be confined rather than spread
>>> out through the code.
>> I did it plibc-style:
>>
>> in compat.h: #if defined(_WIN32) #define FOPEN
>> grabbag__fop
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 18.03.2013 02:37, Erik de Castro Lopo wrote:
> JonY wrote:
>> On 3/17/2013 23:01, LRN wrote:
All those ifdefs will at least be confined rather than spread
out through the code.
>>> I did it plibc-style:
>>>
>>> in compat.h: #if defined(_W
On Mar 17, 2013, at 03:57, LRN wrote:
> /me looks at chmod and utime wrappers:
> Ah, i knew i've missed something! :)
> Also, i didn't consider wildcards (i thought shell was supposed to
> handle them...).
I believe that shell does handle wildcards on all Unix variants,
including OSX. Since Wi
Brian Willoughby wrote:
> I believe that shell does handle wildcards on all Unix variants,
> including OSX.
Yes.
> Since Windows does not handle them, I suggest that the
> main flac code not be littered with code that's not necessary on the
> primary platforms.
No, the flac code will not
16 matches
Mail list logo