Re: [flac-dev] FIxed rest of cast-align warnings

2014-06-29 Thread Erik de Castro Lopo
lvqcl wrote: About a commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=40e817dc526d1d41e900bb0f54d1a4451bda01ed I think it's more consistent to write FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS * sizeof(FLAC__int32)/sizeof(FLAC__int16)]; instead of

Re: [flac-dev] FIxed rest of cast-align warnings

2014-06-29 Thread Erik de Castro Lopo
Martijn van Beurden wrote: op 29-06-14 15:31, Erik de Castro Lopo schreef: I would appreciate it if people could kick this around, test on other platforms/architectures and test for performance regressions. These patches indeed fix the -Wcast-align warnings, but the new MD5 tests fail

Re: [flac-dev] FIxed rest of cast-align warnings

2014-06-29 Thread lvqcl
Erik de Castro Lopo wrote: FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS * sizeof(FLAC__int32)/sizeof(FLAC__int16)]; instead of FLAC__int16 s16buffer[FLAC__MAX_BLOCK_SIZE * FLAC__MAX_CHANNELS * sizeof(FLAC__int16)]; Really? Would you also write this? : FLAC__int32

[flac-dev] [PATCH] stream_encoder : Improve selection of residual accumulator width

2014-06-29 Thread lvqcl
lvqcl wrote: Erik de Castro Lopo wrote: It slightly improves the performance with standard encoding levels and 16-bit files as the 17-bit side channel can still be processed with the 32-bit accumulator and correctly selects the 64-bit accumulator with very large 16-bit partitions. This is