Re: [Flac-dev] total_samples of Ogg Flac file

2006-11-11 Thread Erik de Castro Lopo
Josh Coalson wrote: > right now, the ogg flac encoder does not go back and fill in > missing stuff in the headers like native flac does. Ah, OK. > it will > eventually, but the best thing is to call > FLAC__stream_encoder_set_total_samples_estimate() before > initializing the encoder, that was

Re: [Flac-dev] Re: build issues

2006-11-11 Thread Josh Coalson
--- Ralph Giles <[EMAIL PROTECTED]> wrote: > On Sat, Nov 11, 2006 at 03:03:12PM -0800, Josh Coalson wrote: > > > ok, checked in some fixes that should take care of most of the > > warnings. > > Nice! Current complete set of warnings: > > replaygain.c: In function 'parse_double_': > replaygain.c:

Re: [Flac-dev] total_samples of Ogg Flac file

2006-11-11 Thread Josh Coalson
right now, the ogg flac encoder does not go back and fill in missing stuff in the headers like native flac does. it will eventually, but the best thing is to call FLAC__stream_encoder_set_total_samples_estimate() before initializing the encoder, that was the correct number is written in the STREAM

[Flac-dev] total_samples of Ogg Flac file

2006-11-11 Thread Erik de Castro Lopo
Hi all, I am able to create file containing Flac data encapsulated in an Ogg container. However, when I read the file and its metadata, the total_samples field contains the value zero, even though the file actually does contain samples and the stream does have an end of stream marker. I think s

Re: [Flac-dev] Re: build issues

2006-11-11 Thread Ralph Giles
On Sat, Nov 11, 2006 at 03:03:12PM -0800, Josh Coalson wrote: > ok, checked in some fixes that should take care of most of the > warnings. Nice! Current complete set of warnings: replaygain.c: In function 'parse_double_': replaygain.c:612: warning: comparison between signed and unsigned replayga

Re: [Flac-dev] Re: build issues

2006-11-11 Thread Josh Coalson
--- Ralph Giles <[EMAIL PROTECTED]> wrote: > On Wed, Nov 08, 2006 at 05:28:39PM -0800, Josh Coalson wrote: > > > which tests? for a little while there, test_seeking would fail > > because of an intermittent bug in the seek routine which has been > > fixed. test_flac and test_metaflac are current