[flac-dev] PATCH: bugfix for the previous patch

2014-04-15 Thread lvqcl
I found a bug in my code, in FLAC__CPU_X86_64 branch: encoder-private_-local_fixed_compute_best_predictor_wide is always sets to FLAC__fixed_compute_best_predictor_wide_intrin_sse2. The fix is attached. if_else_fix.patch Description: Binary data ___

Re: [flac-dev] Patch to fix compiler warnings and error status collisions

2014-04-15 Thread Erik de Castro Lopo
Lenny Maiorani wrote: This also causes a warning and looks like it is the wrong #ifdef. ioctl() is only used inside of a '#if !defined __ANDROID__'. Note, this compiler warning was generated when compiling on Mac OSX 10.9 with clang: utils.c:189:6: warning: implicit declaration of

Re: [flac-dev] PATCH: bugfix for the previous patch

2014-04-15 Thread Erik de Castro Lopo
lvqcl wrote: I found a bug in my code, in FLAC__CPU_X86_64 branch: encoder-private_-local_fixed_compute_best_predictor_wide is always sets to FLAC__fixed_compute_best_predictor_wide_intrin_sse2. The fix is attached. Good catch! #ifdef hackery can be rather dangerous! Applied and pushed.