Re: [flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-03 Thread Erik de Castro Lopo
lvqcl wrote: 1) lpc.c, FLAC__lpc_quantize_coefficients(): snip 2) There's the following code in stream_decoder.c: Like you, I don't see a lot of value in these. I think I'll decline these. Cheers, Erik -- -- Erik de

Re: [flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-03 Thread Miroslav Lichvar
On Thu, Jul 03, 2014 at 04:21:59PM +0400, lvqcl wrote: Erik de Castro Lopo wrote: There's the following code in stream_decoder.c: Like you, I don't see a lot of value in these. I think I'll decline these. FLAC__lpc_restore_signal_asm_ia32_mmx compares 'order' argument with 4 and if

[flac-dev] [PATCH] two patches of doubtful usefulness

2014-07-02 Thread lvqcl
1) lpc.c, FLAC__lpc_quantize_coefficients(): This function declares const int nshift = -(*shift) variable when *shift is less than 0. Then nshift is used in the loop: for(i = 0; i order; i++) { error += lp_coeff[i] / (1 nshift); This patch adds const int pshift = *shift variable.