Re: [flac-dev] Typos in the FLAC codebase

2014-06-07 Thread lvqcl
Erik de Castro Lopo wrote: 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the

Re: [flac-dev] Typos in the FLAC codebase

2014-06-01 Thread Erik de Castro Lopo
lvqcl wrote: 1) src/share/grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' - 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, 1 fames)' 'fames' - frames? samples? bytes? Thanks for those two. Fixed and pushed. 3) configure.ac, line

Re: [flac-dev] Typos in the FLAC codebase

2014-06-01 Thread lvqcl
Erik de Castro Lopo wrote: 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 = xtrue)' Not sure about this, but other names inside AM_CONDITIONALs begin with FLaC__, not FLAC__. A quote from configure.ac: NOTE that for many of the AM_CONDITIONALs we use the

Re: [flac-dev] Typos in the FLAC codebase

2014-06-01 Thread lvqcl
Erik de Castro Lopo wrote: But such names (FLaC__NO_ASM, FLaC__CPU_IA32, FLaC__CPU_PPC, FLaC__USE_3DNOW, ...) begin with 'FLaC__' only in configure.ac. In all source files (.c, .h, .cpp) they begin with 'FLAC__' (all caps). Is this possibly the cause of the issue you mentioned in the email

[flac-dev] Typos in the FLAC codebase

2014-05-30 Thread lvqcl
1) src/share/grabbag/snprintf.c, line 42: 'on systems with a norrmal ISO C99' 'norrmal' - 'normal' 2) src/flac/encode.c, line 1661: '(eg, very short files, 1 fames)' 'fames' - frames? samples? bytes? 3) configure.ac, line 140: 'AM_CONDITIONAL(FLAC__CPU_X86_64, test x$cpu_x86_64 =