Martijn van Beurden wrote:
I was running make fullcheck when I found something weird. After editing
the *expect.meta files , make fullcheck ran all tests and said All
tests passed, but the output included this (this is the last tests from
test_metaflac.sh)
[...]
test case60: --remove
On 24.4.2013 15:42, Erik de Castro Lopo wrote:
Janne Hyvärinen wrote:
+#define PPR if(filename) if(raw) printf(%s:,filename); else
flac_printf(%s:,filename);
Are you sure about that line?
GCC complains about an ambiguous 'else'. It definitely needs some
curly braces somewhere there to
Janne Hyvärinen wrote:
Changing it to #define PPR if(filename) { if(raw) {
printf(%s:,filename); } else { flac_printf(%s:,filename); } }
Thanks. Applied.
makes GCC happy.
Its really about more than making GCC happy. The if statement
was genuinely an ambiguous compile. See the 'Dangling
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk links to mawk 1.3.3
Yep fails on
Erik de Castro Lopo wrote:
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk
