Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2021-07-17 Thread Martijn van Beurden
Op ma 6 jul. 2020 om 10:22 schreef Erik de Castro Lopo : > > Martijn van Beurden wrote: > > > To trigger this overflow, one has to force rice_parameter to 0 > > Ok, that sounds dodgy. Yes, well, it is. It could very well be that without patching, nobody ever has a problem with this, but as the

Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-09 Thread Martijn van Beurden
Op do 9 jul. 2020 om 00:07 schreef Erik de Castro Lopo : > Would it be possible to submit these patches as a PR on Github? > I just did for the patches against the flac source. However, the flac-website github repository doesn't seem synced with the xiph one, so I can't patch that one. Kind

Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-08 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > > P.S.: I'm sending this for the second time, sorry if it arrives twice. > It seems to me e-mails over 50kb don't get through. Would it be possible to submit these patches as a PR on Github? Thanks, Erik --

Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-06 Thread Martijn van Beurden
Op ma 6 jul. 2020 om 10:22 schreef Erik de Castro Lopo : > > Martijn van Beurden wrote: > > > To trigger this overflow, one has to force rice_parameter to 0 > > Ok, that sounds dodgy. Yes, well, it is. It could very well be that without patching, nobody ever has a problem with this, but as the

Re: [flac-dev] Possible overflow of _candidate_bits in stream_encoder.c

2020-07-06 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > To trigger this overflow, one has to force rice_parameter to 0 Ok, that sounds dodgy. > in for > example the function evaluate_lpc_subframe in libFLAC/stream_encoder.c. > When encoding noisy material, which needs a high rice parameter, it can > happen that the