On 25-04-13 05:30, Erik de Castro Lopo wrote:
The problem is that the failure in the awk script isn't recognised as
a failure in the shell script.
No, really, it's not only that. With the fixed git, I get this when I
change one of the expected values to something else:
[...]
Testing FLAC
Martijn van Beurden wrote:
I also found a possible solution: using set -e just above that
replaygain test for loop. That should exit the whole script if a single
line returns an non-zero exit status, which makes it possible to let
'exit' abort not only the loop but the whole script. Maybe
On 25-04-13 11:38, Erik de Castro Lopo wrote:
Lets see the patch first and then see if we can make it prettier.
Erik
Sure. Patch attached.
From bae4658ef6f18db9bb8c49fecd01f6eade25554a Mon Sep 17 00:00:00 2001
From: Martijn van Beurden mva...@gmail.com
Date: Thu, 25 Apr 2013 15:20:23 +0200
Sorry, I'm making a big mess of this. Please ignore the previous one. I
used set -x instead of set -e
On 25-04-13 15:25, Martijn van Beurden wrote:
On 25-04-13 11:38, Erik de Castro Lopo wrote:
Lets see the patch first and then see if we can make it prettier.
Erik
Sure. Patch attached.
Martijn van Beurden wrote:
Sorry, I'm making a big mess of this. Please ignore the previous one. I
used set -x instead of set -e
On 25-04-13 15:25, Martijn van Beurden wrote:
On 25-04-13 11:38, Erik de Castro Lopo wrote:
Lets see the patch first and then see if we can make it prettier.
Martijn van Beurden wrote:
I was running make fullcheck when I found something weird. After editing
the *expect.meta files , make fullcheck ran all tests and said All
tests passed, but the output included this (this is the last tests from
test_metaflac.sh)
[...]
test case60: --remove
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk links to mawk 1.3.3
Yep fails on
Erik de Castro Lopo wrote:
Martijn van Beurden wrote:
On 24-04-13 14:34, Erik de Castro Lopo wrote:
That's an error in the awk script, which is embedded in the shell
script. I know GNU awk supports lshift, maybe BSD awk doesn't. I'll
investigate that futher.
On my system awk
