Re: [Flashcoders] Code review, please

2006-09-25 Thread Andreas Rønning
If you aren't you should Knee jerk reaction: Nobody should use any pattern. They CAN use patterns if it benefits the project, benefits their mental health and provides for a better product. I probably read too much into it but pattern worship is useless, crippling and annoying. - A Per

Re: [Flashcoders] Code review, please

2006-09-25 Thread Alias™
Hear hear. Patterns are no magic bullet. Alias On 25/09/06, Andreas Rønning [EMAIL PROTECTED] wrote: If you aren't you should Knee jerk reaction: Nobody should use any pattern. They CAN use patterns if it benefits the project, benefits their mental health and provides for a better product.

Re: [Flashcoders] Code review, please

2006-09-25 Thread Anggie Bratadinata
1. Comment your code! Ah, yes, of course. Sorry about that. I'll comment it right away. 2. Are you using the MVC pattern? It's not really clear from the code, but it looks somewhat like it nope, I don't use pattern. I just want to make the HistoryList and HistoryItem 'talk' to each other. I

[Flashcoders] Code review, please

2006-09-24 Thread Anggie Bratadinata
Folks, I hope it's okay for a noob like me to ask for a code review here. If not, sorry for the noise. This is the simple app I created a few days ago, about which I'd like to have your expert advice on how to improve it or maybe how to code it in a much better way.

Re: [Flashcoders] Code review, please

2006-09-24 Thread Per Bolmstedt
Anggie Bratadinata wrote: This is the simple app I created a few days ago, about which I'd like to have your expert advice on how to improve it or maybe how to code it in a much better way. 1. Comment your code! It looks structured enough, so adding comments should be easy. If you use FDT,