Re: [flashrom] [PATCH] Move implicit erase out of chip drivers, clean up

2010-10-08 Thread Carl-Daniel Hailfinger
On 08.10.2010 19:11, Carl-Daniel Hailfinger wrote: flashrom had an implicit erase-on-write for most flash chip and programmer drivers, but it was not entirely consistent. Some drivers had their own hand-rolled partial update functionality which made handling partial updates from generic code

Re: [flashrom] [PATCH] Move implicit erase out of chip drivers, clean up

2010-07-27 Thread Uwe Hermann
On Sat, Jul 17, 2010 at 12:18:49AM +0200, Carl-Daniel Hailfinger wrote: New version, updated to apply against current svn. flashrom had an implicit erase-on-write for most flash chip and ^

Re: [flashrom] [PATCH] Move implicit erase out of chip drivers, clean up

2010-07-14 Thread Carl-Daniel Hailfinger
On 10.07.2010 21:25, Carl-Daniel Hailfinger wrote: On 10.07.2010 20:16, Michael Karcher wrote: The M29F400 stuff is completely broken. We use write_coreboot_m29f400bt everywhere and write_m29f400bt is dead code. But write_coreboot_m29f400bt does just write the lower half of the chip

Re: [flashrom] [PATCH] Move implicit erase out of chip drivers, clean up

2010-07-14 Thread Carl-Daniel Hailfinger
flashrom had an implicit erase-on-write for most flash chip and programmer drivers, but it was not entirely consistent. Some drivers had their own hand-rolled partial update functionality which made handling partial updates from generic code impossible. Move implicit erase out of chip drivers,

Re: [flashrom] [PATCH] Move implicit erase out of chip drivers, clean up

2010-07-10 Thread Carl-Daniel Hailfinger
On 10.07.2010 20:16, Michael Karcher wrote: Am Samstag, den 22.05.2010, 03:26 +0200 schrieb Carl-Daniel Hailfinger: [as requested on IRC, this is not a full review, but two things not directly related to the patch stand out I don't want to leave uncommented] int