Am Montag, den 12.07.2010, 03:23 +0200 schrieb Carl-Daniel Hailfinger:
Thanks! Your suggestions indeed make sense, and the code is now a lot
simpler. New version follows.
I'm not sure if I should move start+=len into the counting expression of
the for loop. Comments welcome.
My personal
On 12.07.2010 08:40, Michael Karcher wrote:
Am Montag, den 12.07.2010, 03:23 +0200 schrieb Carl-Daniel Hailfinger:
Thanks! Your suggestions indeed make sense, and the code is now a lot
simpler. New version follows.
I'm not sure if I should move start+=len into the counting expression of
On 10.07.2010 20:39, Michael Karcher wrote:
You are just moving this code, but I still have a comment on it: Why
don't you increase done here? You don't need the start variable any
more and you don't have to write the explicit multiplication below.
Yes, that code is a leftover from
Split erase region walking out of erase_flash.
That allows us to use erase region walking for a combined erase/write
action, and is a prerequisite for partial flashing.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net
Index: flashrom-walk_eraseregions/flashrom.c
