[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-08 Thread Anastasia Klimchuk
I really like how we collectively debugged the issue and identified the root cause, even without Alex responding. This is so cool, thanks everyone! <3 Alex, Yes it's true that makefile will be deleted soon, probably later this year. It's a very good time to switch to meson, and please complain

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-07 Thread Stefan Reinauer via flashrom
On Fri, Apr 7, 2023, 03:42 Edward O'Callaghan wrote: > > > On Fri, 7 Apr 2023 at 15:52, Stefan Reinauer > wrote: > >> You should also be able to just say "make flashrom" instead of just >> "make" or "make all" >> > > Stefan, > > I think the longer term intent is to EOL the Makefile in favour of

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-07 Thread Edward O'Callaghan via flashrom
On Fri, 7 Apr 2023 at 15:52, Stefan Reinauer wrote: > You should also be able to just say "make flashrom" instead of just "make" > or "make all" > Stefan, I think the longer term intent is to EOL the Makefile in favour of meson. The last release was about feature parity between the two build

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-06 Thread Stefan Reinauer via flashrom
You should also be able to just say "make flashrom" instead of just "make" or "make all" On Thu, Apr 6, 2023 at 10:42 PM Thomas Heijligen wrote: > Yea, there is a error in the Makefile logic which requires sphix when run > 'make [all]'. I'll fix this. > > To mitigate this in the meanwhile you

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-06 Thread Thomas Heijligen
Yea, there is a error in the Makefile logic which requires sphix when run 'make [all]'. I'll fix this. To mitigate this in the meanwhile you can comment out Makefile line 1035 'FLASHROM_VERSION=$(VERSION) $(SPHINXBUILD) -b man doc .' Please be aware, that we are in the process of switching to

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-06 Thread Anastasia Klimchuk
Hi Alex, This is definitely not intended behaviour: sphinx is optional. If it is not present, flashrom can be built, just without docs. I didn't have sphinx locally for a while, and was building the sources without it. Only installed it very recently, because I started to add docs. Can you tell

[flashrom] Re: Unable to build flashrom from git repo without sphinx

2023-04-06 Thread Edward O'Callaghan via flashrom
CC: Thomas who knows this part best. Hey Alex, Thanks for the report! My impression was that if the dependencies are not found documentation should not be built, it should be optional. Was this via the Makefile or meson and was this Tip of Tree or a release tarball? Could you also provide a log