Re: [flashrom] DMI matching patch

2010-01-08 Thread Luc Verhaegen
On Thu, Jan 07, 2010 at 05:25:32PM +0100, Carl-Daniel Hailfinger wrote: On 07.01.2010 16:46, Luc Verhaegen wrote: I do not expect DMI many match policy changes. * We've been relatively happy with pci subsystem ids for close to three years. Yes, but that isn't a match-any policy

Re: [flashrom] DMI matching patch

2010-01-08 Thread Luc Verhaegen
On Thu, Jan 07, 2010 at 11:29:32AM +0100, Michael Karcher wrote: Am Donnerstag, den 07.01.2010, 10:30 +0100 schrieb Luc Verhaegen: I am just warning that dmi might not be as tight and enduring as many people think it is, and that therefor it should be used with some care. For the

Re: [flashrom] DMI matching patch

2010-01-08 Thread Luc Verhaegen
On Thu, Jan 07, 2010 at 03:50:19PM +0100, Carl-Daniel Hailfinger wrote: On 07.01.2010 15:43, Luc Verhaegen wrote: The prefix is A Bad Thing. As shown before, a typo is easily made, and we cannot check for it. Have you seen the selfcheck() function which is called on startup? I have

Re: [flashrom] Abit AN-M2

2010-01-08 Thread Carl-Daniel Hailfinger
On 08.01.2010 13:18, Luc Verhaegen wrote: On Thu, Jan 07, 2010 at 09:39:51PM +0100, Carl-Daniel Hailfinger wrote: On 03.12.2009 00:30, Luc Verhaegen wrote: On Mon, Nov 09, 2009 at 07:39:52PM -0300, NotLim wrote: I need a board enable. My motherboard is an Abit AN-M2.

Re: [flashrom] Board Enable for MSI 651M-L

2010-01-08 Thread Michael Karcher
Am Freitag, den 08.01.2010, 02:44 +0100 schrieb Michael Karcher: Hello, This patch should enable flash read/write on the MSI 651M-L. Please test. DuratarskeyK: This is your board. Please report success or failure (with output of flashrom -V) to the mailing list. That patch is wrong. I

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread Anthony DeRosa
carldani, Requested output below. Invalid opcode? The MX25L8005 datasheet says the part supports opcode 0x03, read data. -Anthony ubu...@ubuntu:~/flashrom$ sudo ./flashrom -c MX25L8005 -V -r backup.bin flashrom v0.9.1-r837 No coreboot table found. Found chipset Intel ICH8/ICH8R, enabling

[flashrom] [patch] NetBSD support

2010-01-08 Thread Jonathan A. Kollasch
Add support for NetBSD. Signed-off-by: Jonathan A. Kollasch jakll...@kollasch.net --- Index: hwaccess.h === --- hwaccess.h (revision 837) +++ hwaccess.h (working copy) @@ -76,6 +76,19 @@ #endif #endif +#if defined(__NetBSD__)

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread Adrian Glaubitz
Hi Anthony, On Fri, Jan 8, 2010 at 4:16 PM, Anthony DeRosa anth...@ransomed.us wrote: carldani, Requested output below.  Invalid opcode?  The MX25L8005 datasheet says the part supports opcode 0x03, read data. IIRC the newer Dell OptiPlex series have a special way for flashing the BIOS. You

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread ron minnich
On Fri, Jan 8, 2010 at 8:32 AM, Adrian Glaubitz adrian.glaub...@googlemail.com wrote: IIRC the newer Dell OptiPlex series have a special way for flashing the BIOS. You use a Dell-provided utility to copy the new BIOS image into a special (non-volatile?) memory, then reboot the machine. Once

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread Carl-Daniel Hailfinger
On 08.01.2010 18:06, ron minnich wrote: On Fri, Jan 8, 2010 at 8:32 AM, Adrian Glaubitz wrote IIRC the newer Dell OptiPlex series have a special way for flashing the BIOS. You use a Dell-provided utility to copy the new BIOS image into a special (non-volatile?) memory, then reboot the machine.

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread Carl-Daniel Hailfinger
On 08.01.2010 16:16, Anthony DeRosa wrote: Requested output below. Invalid opcode? The MX25L8005 datasheet says the part supports opcode 0x03, read data. As discussed on IRC, the READ opcode 0x03 is not supported by your chipset configuration. ubu...@ubuntu:~/flashrom$ sudo ./flashrom

Re: [flashrom] [patch] NetBSD support

2010-01-08 Thread Carl-Daniel Hailfinger
On 08.01.2010 17:22, Jonathan A. Kollasch wrote: Add support for NetBSD. Signed-off-by: Jonathan A. Kollasch jakll...@kollasch.net Thanks for your patch. There are a few things I'd like to see changed before committing, though. Index: hwaccess.h

[flashrom] [PATCH] Allow single-programmer compilation

2010-01-08 Thread Carl-Daniel Hailfinger
If neither internal (old default) nor dummy (safe default) programmer are selected, we must pick a sensible default programmer. Since there is no reason to prefer a particular external programmer, we abort compilation if more than one of them is selected. If only one is selected, it is clear that

[flashrom] [patch-v2] NetBSD support

2010-01-08 Thread Jonathan A. Kollasch
Add support for NetBSD. Signed-off-by: Jonathan A. Kollasch jakll...@kollasch.net --- Index: hwaccess.h === --- hwaccess.h (revision 837) +++ hwaccess.h (working copy) @@ -76,6 +76,63 @@ #endif #endif +#if defined(__NetBSD__) +

Re: [flashrom] [patch-v2] NetBSD support

2010-01-08 Thread Carl-Daniel Hailfinger
On 08.01.2010 21:28, Jonathan A. Kollasch wrote: Add support for NetBSD. Signed-off-by: Jonathan A. Kollasch jakll...@kollasch.net Thanks for the patch. Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2...@gmx.net and committed in r838. Regards, Carl-Daniel -- Developer quote of

Re: [flashrom] Error Reading BIOS on Dell Optiplex 745

2010-01-08 Thread Joerg Mayer
On Fri, Jan 08, 2010 at 09:06:52AM -0800, ron minnich wrote: On Fri, Jan 8, 2010 at 8:32 AM, Adrian Glaubitz adrian.glaub...@googlemail.com wrote: IIRC the newer Dell OptiPlex series have a special way for flashing the BIOS. You use a Dell-provided utility to copy the new BIOS image into

[flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Sean Nelson
This patch should have all chips from A to M converted to struct block erasers. Converted chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon EN25B10 Eon EN25B20 Eon EN25B40 Eon EN25B80 Eon EN25B16 Eon EN25B32 Eon EN25B64 Eon EN25D16 Eon EN25F05

Re: [flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Sean Nelson
On 1/8/10 2:33 PM, Sean Nelson wrote: This patch should have all chips from A to M converted to struct block erasers. Converted chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon EN25B10 Eon EN25B20 Eon EN25B40 Eon EN25B80 Eon EN25B16 Eon

Re: [flashrom] [PATCH] Use address mask in probe_jedec

2010-01-08 Thread Sean Nelson
On 1/7/2010 1:22 PM, Carl-Daniel Hailfinger wrote: int probe_jedec(struct flashchip *flash) { - return probe_jedec_common(flash, MASK_FULL, 1); + int mask; + + mask = getaddrmask(flash); + return probe_jedec_common(flash, mask, 1); } int erase_sector_jedec(struct

[flashrom] [commit] r839 - trunk

2010-01-08 Thread svn
Author: hailfinger Date: 2010-01-09 03:24:17 +0100 (Sat, 09 Jan 2010) New Revision: 839 Modified: trunk/flashchips.c trunk/jedec.c trunk/pm49fl00x.c trunk/sst_fwhub.c trunk/stm50flw0x0x.c trunk/w39v080fa.c Log: Use the register mapping feature bit. All functions which just call

[flashrom] [commit] r840 - trunk

2010-01-08 Thread svn
Author: hailfinger Date: 2010-01-09 04:15:50 +0100 (Sat, 09 Jan 2010) New Revision: 840 Modified: trunk/flash.h trunk/jedec.c Log: Use address mask in probe_jedec. This allows us to have one common probe_jedec function instead of half a dozen wrappers. The trick here is to have

Re: [flashrom] [PATCH] Use address mask in probe_jedec

2010-01-08 Thread Carl-Daniel Hailfinger
On 09.01.2010 01:44, Sean Nelson wrote: On 1/7/2010 1:22 PM, Carl-Daniel Hailfinger wrote: int probe_jedec(struct flashchip *flash) { -return probe_jedec_common(flash, MASK_FULL, 1); +int mask; + +mask = getaddrmask(flash); +return probe_jedec_common(flash, mask, 1);

Re: [flashrom] [PATCH] Fix up msg_* macros

2010-01-08 Thread Sean Nelson
On 1/8/2010 7:13 PM, Carl-Daniel Hailfinger wrote: This slipped through the review. The msg_* macros won't compile as is if you use more than one parameter (i.e. have a format string and a variable). There are two alternative styles: GNU or C99 variadic macros. While C99 has limitations compared

Re: [flashrom] [PATCH] Fix up msg_* macros

2010-01-08 Thread Carl-Daniel Hailfinger
On 09.01.2010 04:17, Sean Nelson wrote: On 1/8/2010 7:13 PM, Carl-Daniel Hailfinger wrote: The msg_* macros won't compile as is if you use more than one parameter (i.e. have a format string and a variable). I didn't even know about that, kinda strange that flashrom compiled fine on my

[flashrom] [PATCH] Convert dummyflasher to msg_*

2010-01-08 Thread Carl-Daniel Hailfinger
Convert dummyflasher to msg_* and make good use of msg_pspew. Rule of thumb: Diagnostic programmer init messages are msg_pdbg, all other debug stuff (except warnings, which should be pmsg_pinfo or msg_perr) is msg_pspew. This makes flashrom -p dummy -V output a whole lot more readable (try it!).

Re: [flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Sean Nelson
Convert chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon EN25B10 Eon EN25B20 Eon EN25B40 Eon EN25B80 Eon EN25B16 Eon EN25B32 Eon EN25B64 Eon EN25D16 Eon EN25F05 Eon EN25F10 Eon EN25F20 Eon EN25F40 Eon EN25F80 Eon EN25F16 Eon EN25F32 Intel

Re: [flashrom] [PATCH] Convert dummyflasher to msg_*

2010-01-08 Thread Sean Nelson
Sweet! Acked-by: Sean Nelson audiohac...@gmail.com ___ flashrom mailing list flashrom@flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom

Re: [flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Carl-Daniel Hailfinger
On 09.01.2010 04:51, Sean Nelson wrote: Convert chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon EN25B10 Eon EN25B20 Eon EN25B40 Eon EN25B80 Eon EN25B16 Eon EN25B32 Eon EN25B64 Eon EN25D16 Eon EN25F05 Eon EN25F10 Eon EN25F20

[flashrom] [commit] r842 - trunk

2010-01-08 Thread svn
Author: hailfinger Date: 2010-01-09 05:32:23 +0100 (Sat, 09 Jan 2010) New Revision: 842 Modified: trunk/dummyflasher.c Log: Convert dummyflasher to msg_* and make good use of msg_pspew. Rule of thumb: Diagnostic programmer init messages are msg_pdbg, all other debug stuff (except warnings,

Re: [flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Sean Nelson
This should compile now, also diff'ed against r842. diff --git a/82802ab.c b/82802ab.c index 58d3467..dfe81e8 100644 --- a/82802ab.c +++ b/82802ab.c @@ -90,32 +90,32 @@ uint8_t wait_82802ab(chipaddr bios) return status; } -int erase_82802ab_block(struct flashchip *flash, int offset)

Re: [flashrom] [PATCH] Convert chips to block erasers: ASD, AMIC, EMST, Eon, Intel, Macronix

2010-01-08 Thread Sean Nelson
Convert chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon EN25B10 Eon EN25B20 Eon EN25B40 Eon EN25B80 Eon EN25B16 Eon EN25B32 Eon EN25B64 Eon EN25D16 Eon EN25F05 Eon EN25F10 Eon EN25F20 Eon EN25F40 Eon EN25F80 Eon EN25F16 Eon EN25F32 Intel

[flashrom] [commit] r843 - trunk

2010-01-08 Thread svn
Author: snelson Date: 2010-01-09 06:30:14 +0100 (Sat, 09 Jan 2010) New Revision: 843 Modified: trunk/82802ab.c trunk/chipdrivers.h trunk/flashchips.c trunk/flashchips.h Log: Convert chips to block_erasers: ASD AE49F2008 AMIC A25L40P(T/U) AMIC A49LF040A EMST F49B002UA Eon EN25B05 Eon

Re: [flashrom] [PATCH] Fix Makefile dependencies if FT2232SPI is not selected

2010-01-08 Thread Sean Nelson
Acked-by: Sean Nelson audiohac...@gmail.com ___ flashrom mailing list flashrom@flashrom.org http://www.flashrom.org/mailman/listinfo/flashrom