Re: [flashrom] [PATCH] add board enable for apple iMac5,2
Stefan Tauner writes: > On Mon, 19 Sep 2016 00:36:23 +0200 > Arthur Heymans wrote: > >> Stefan Tauner writes: >> >> > On Sun, 18 Sep 2016 20:42:19 +0200 >> > Arthur Heymans wrote: >> > >> >> Hi >> >> >> >> This patch adds the apple iMac5,2 to board enable. The hardware is very >> >> similar to the apple macbook2,1. >> >> >> > >> > Hell Arthur, >> > >> > thanks for your patch (which seems to became mangled by your MUA btw). >> > If flashrom works r/w with that iMac we should add it to print.c as >> > well. Do you have any verbose logs showing that it does actually work? >> >> r/w works but it seems to require a few tries of erase functions. >> Board mismatch was used because it was previously flashed with a >> macbook21 coreboot rom (coreboot works on this board). > > I'd like to investigate those errors. However, I think you did create > the log with i/o redirection instead of using the -o parameter and > forgot to include stderr and thus the most interesting message(s) are > missing from the log. I think the vendor bios sets BP0-2. On coreboot there are no problems. -- Arthur Heymans flashrom v0.9.9-r1955 on Linux 4.7.3-gnu (x86_64) flashrom is free software, get the source code at https://flashrom.org flashrom was built with libpci 3.2.1, GCC 4.9.2, little endian Command line (7 args): ./flashrom -p internal -w coreboot_good_grub.rom -o output.log -VV Calibrating delay loop... OS timer resolution is 2 usecs, 904M loops per second, 10 myus = 11 us, 100 myus = 103 us, 1000 myus = 994 us, 1 myus = 9985 us, 8 myus = 9 us, OK. Initializing internal programmer No coreboot table found. Using Internal DMI decoder. DMI chassis-type is not specific enough. DMI string system-manufacturer: "Apple Computer, Inc." DMI string system-product-name: "iMac5,2" DMI string system-version: "1.0" DMI string baseboard-manufacturer: "Apple Computer, Inc." DMI string baseboard-product-name: "Mac-F4218EC8" DMI string baseboard-version: "DVT" Whitelisted laptop detected. Found chipset "Intel ICH7M" with PCI ID 8086:27b9. Enabling flash write... Root Complex Register Block address = 0xfed1c000 GCS = 0x200461: BIOS Interface Lock-Down: enabled, Boot BIOS Straps: 0x1 (SPI) Top Swap: enabled (A16(+) inverted) 0xfff8/0xffb8 FWH IDSEL: 0x0 0xfff0/0xffb0 FWH IDSEL: 0x0 0xffe8/0xffa8 FWH IDSEL: 0x0 0xffe0/0xffa0 FWH IDSEL: 0x0 0xffd8/0xff98 FWH IDSEL: 0x2 0xffd0/0xff90 FWH IDSEL: 0x2 0xffc8/0xff88 FWH IDSEL: 0x3 0xffc0/0xff80 FWH IDSEL: 0x3 0xff70/0xff30 FWH IDSEL: 0x4 0xff60/0xff20 FWH IDSEL: 0x5 0xff50/0xff10 FWH IDSEL: 0x6 0xff40/0xff00 FWH IDSEL: 0x7 0xfff8/0xffb8 FWH decode enabled 0xfff0/0xffb0 FWH decode enabled 0xffe8/0xffa8 FWH decode enabled 0xffe0/0xffa0 FWH decode enabled 0xffd8/0xff98 FWH decode enabled 0xffd0/0xff90 FWH decode enabled 0xffc8/0xff88 FWH decode enabled 0xffc0/0xff80 FWH decode enabled 0xff70/0xff30 FWH decode disabled 0xff60/0xff20 FWH decode disabled 0xff50/0xff10 FWH decode disabled 0xff40/0xff00 FWH decode disabled Maximum FWH chip size: 0x20 bytes SPI Read Configuration: prefetching disabled, caching enabled, BIOS_CNTL = 0x01: BIOS Lock Enable: disabled, BIOS Write Enable: enabled SPIBAR = 0x7fe139c0a000 + 0x3020 0x00: 0x0004 (SPIS) 0x02: 0x4020 (SPIC) 0x04: 0x (SPIA) 0x50: 0x (BBAR) 0x54: 0x5006 (PREOP) 0x56: 0x7f48 (OPTYPE) 0x58: 0x0405039f (OPMENU) 0x5c: 0x0102d820 (OPMENU+4) 0x60: 0x80faf000 (PBR0) 0x64: 0x8000 (PBR1) 0x68: 0x80e0 (PBR2) Programming OPCODES... program_opcodes: preop=5006 optype=463b opmenu=05d80302c79f0190 done OPType Pre-OP op[0]: 0x02, write w/ addr, none op[1]: 0x03, read w/ addr, none op[2]: 0xd8, write w/ addr, none op[3]: 0x05, read w/o addr, none op[4]: 0x90, read w/ addr, none op[5]: 0x01, write w/o addr, none op[6]: 0x9f, read w/o addr, none op[7]: 0xc7, write w/o addr, none Pre-OP 0: 0x06, Pre-OP 1: 0x50 OK. The following protocols are supported: FWH, SPI. Probing for AMIC A25L05PT, 64 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L05PU, 64 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L10PT, 128 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L10PU, 128 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L20PT, 256 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L20PU, 256 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L40PT, 512 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L40PU, 512 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L80P, 1024 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L16PT, 2048 kB: probe_spi_rdid_generic: id1 0xbf, id2 0x2541 Probing for AMIC A25L16PU, 2048 kB: probe_spi_
Re: [flashrom] [PATCH] add board enable for apple iMac5,2
On Mon, 19 Sep 2016 00:36:23 +0200 Arthur Heymans wrote: > Stefan Tauner writes: > > > On Sun, 18 Sep 2016 20:42:19 +0200 > > Arthur Heymans wrote: > > > >> Hi > >> > >> This patch adds the apple iMac5,2 to board enable. The hardware is very > >> similar to the apple macbook2,1. > >> > > > > Hell Arthur, > > > > thanks for your patch (which seems to became mangled by your MUA btw). > > If flashrom works r/w with that iMac we should add it to print.c as > > well. Do you have any verbose logs showing that it does actually work? > > r/w works but it seems to require a few tries of erase functions. > Board mismatch was used because it was previously flashed with a > macbook21 coreboot rom (coreboot works on this board). I'd like to investigate those errors. However, I think you did create the log with i/o redirection instead of using the -o parameter and forgot to include stderr and thus the most interesting message(s) are missing from the log. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner ___ flashrom mailing list flashrom@flashrom.org https://www.flashrom.org/mailman/listinfo/flashrom
Re: [flashrom] [PATCH] add board enable for apple iMac5,2
On Sun, 18 Sep 2016 20:42:19 +0200 Arthur Heymans wrote: > Hi > > This patch adds the apple iMac5,2 to board enable. The hardware is very > similar to the apple macbook2,1. > Hell Arthur, thanks for your patch (which seems to became mangled by your MUA btw). If flashrom works r/w with that iMac we should add it to print.c as well. Do you have any verbose logs showing that it does actually work? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner ___ flashrom mailing list flashrom@flashrom.org https://www.flashrom.org/mailman/listinfo/flashrom
[flashrom] [PATCH] add board enable for apple iMac5,2
Hi
This patch adds the apple iMac5,2 to board enable. The hardware is very
similar to the apple macbook2,1.
>From 1b0d44e2f81a7967e6a9caf07f25c029f4d06a47 Mon Sep 17 00:00:00 2001
From: Arthur Heymans
Date: Sun, 18 Sep 2016 20:35:50 +0200
Subject: [PATCH] Add board enable for iMac5,2
Signed-off-by: Arthur Heymans
diff --git a/board_enable.c b/board_enable.c
index 2f0c1c0..1b7b4ee 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -2326,6 +2326,7 @@ const struct board_match board_matches[] = {
{0x8086, 0x27b9, 0xa0a0, 0x0632, 0x8086, 0x27da, 0xa0a0, 0x0632, NULL, NULL, NULL, P3, "AOpen", "i945GMx-VFX", 0, OK, intel_ich_gpio38_raise},
{0x8086, 0x277c, 0xa0a0, 0x060b, 0x8086, 0x27da, 0xa0a0, 0x060b, NULL, NULL, NULL, P3, "AOpen", "i975Xa-YDG",0, OK, board_aopen_i975xa_ydg},
{0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^MacBook2,1$", NULL, NULL, P2, "Apple", "MacBook2,1",0, OK, p2_whitelist_laptop},
+ {0x8086, 0x27A0, 0x8086, 0x7270, 0x8086, 0x27B9, 0x8086, 0x7270, "^iMac5,2$", NULL, NULL,P2, "Apple", "iMac5,2", 0, OK, p2_whitelist_laptop},
{0x8086, 0x27b8, 0x1849, 0x27b8, 0x8086, 0x27da, 0x1849, 0x27da, "^ConRoeXFire-eSATA2", NULL, NULL, P3, "ASRock", "ConRoeXFire-eSATA2",0, OK, intel_ich_gpio16_raise},
{0x1022, 0x1536, 0x1849, 0x1536, 0x1022, 0x780e, 0x1849, 0x780e, "^Kabini CRB$", NULL, NULL, P2, "ASRock", "IMB-A180(-H)", 0, OK, p2_not_a_laptop},
{0x1039, 0x0741, 0x1849, 0x0741, 0x1039, 0x5513, 0x1849, 0x5513, "^K7S41 $", NULL, NULL, P3, "ASRock", "K7S41", 0, OK, w836xx_memw_enable_2e},
--
2.9.3
___
flashrom mailing list
flashrom@flashrom.org
https://www.flashrom.org/mailman/listinfo/flashrom
