Huh, I guess Github isn't smart enough to figure out that that commit was a
manual merge of the PR, so it shows up as "closed" instead of "merged". But
don't worry, the actual changes are merged :)
Also, I fixed up the author name on your commit to use your full name; that is
good practice, so
git --amend will also add any new changes to the existing commit, not just
change the commit message. It's a way to keep the history "clean" (having one
logical commit) while making changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Closed #192 via 55597375caa819a43c3719171b82921d7dc6ad66.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/192#event-2845484024___
Flent-users
And thank you very much!!
El lun., 2 de diciembre de 2019 9:21, Emilly Oliveira <
emilly.olive...@ccc.ufcg.edu.br> escribió:
> The second one has some changes in the code and I wasn't sure if --amend
> would amend everything or just the commit message.
>
> El lun., 2 de diciembre de 2019 9:19,
The second one has some changes in the code and I wasn't sure if --amend
would amend everything or just the commit message.
El lun., 2 de diciembre de 2019 9:19, Toke Høiland-Jørgensen <
notificati...@github.com> escribió:
> *@tohojo* approved this pull request.
>
> The changes look good now,
tohojo approved this pull request.
The changes look good now, great work! :)
It seems there are two commits in the pull request; I guess you created a new
one instead of amending the original one? I can fix this and squash them
together when merging, but just something to be aware of next time
@emys-alb pushed 1 commit.
d5ec808bc73d00a2e18ce1a8faedb1d3f976855e metadata: Add parsing of WiFi status
information
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
tohojo requested changes on this pull request.
Looking good! Only a few minor details to fix.
Also, please add some text to the commit message explaining the change; only
needs to be a line or two for this (put that before the signed-off-by).
> +
+for line in output.splitlines():
+
+
Created a function called get_wifi_data() that gathers information about the
wifi status at one dictionary.
Output:
{addr: 50:b7:c3:c9:1c:8c,
channel: {band: 2462, center1: 2462,
number: 11, width: 20},
ssid: VIVO-81A0,
txpower: 15.0,
type: managed}
You can view, comment
