Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-28 Thread Carlos Rovira
Hi Alex, I think it's ok now. I choose another image from Assets/Images directory and could uncomment an AssertEvent, so I think you should not find any issue more. check it in: https://issues.apache.org/jira/browse/FLEX-33180#comment-13443042 Best, Carlos 2012/8/27 Alex Harui : > > > > On 8

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-27 Thread Alex Harui
On 8/27/12 1:17 AM, "Carlos Rovira" wrote: > Hi Alex, I compare [1] the remote custom_headerRenderersAS.png with > the local one and see that the missing asset is a cyan ball. As you > say is not there any more (maybe due to copyright?)...I think that png > should be commited. What do you thin

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-27 Thread Carlos Rovira
Hi alex, I just create a patch to exclude rpc test that are relying on adobe internal server https://issues.apache.org/jira/browse/FLEX-33181#comment-13442458 patch is here: https://github.com/apache/flex/pull/16.patch runs ok: [java] =

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-27 Thread Carlos Rovira
Hi Alex, I compare [1] the remote custom_headerRenderersAS.png with the local one and see that the missing asset is a cyan ball. As you say is not there any more (maybe due to copyright?)...I think that png should be commited. What do you think? [1] https://dl.dropbox.com/u/8496144/COMPARISION_cus

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-27 Thread Carlos Rovira
Right Alex, my frist commit was only the five files modified, but I package all the changes of the run due to the Peter's commit. Since the changes are due to location modification in the mouse I think is valid (we are not testing things related to the bitmap itself and we should don't care if the

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Alex Harui
On 8/26/12 12:30 PM, "Carlos Rovira" wrote: > Hi Alex, > > as I see you and Peter was able to deal with Jose Barragan's patches > vía github, I created this patch in the same way and create the JIRA > ticket as well (both are referenced from one to another): > > JIRA ticket: > https://issues

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Alex Harui
On 8/26/12 12:56 PM, "Carlos Rovira" wrote: > "tests/rpc" is failing due to a service hosted in adobe services [1], > so should deactivated it? (Peter said that if some test rely on some > adobe service we should comment the test). The errors are like this: > > faultCode = "Server.Error.Reques

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Carlos Rovira
I'm now with "tests/RuntimeLocalization/" and this reports 6 errors: ./mini_run.sh -createImages tests/RuntimeLocalization/ [java] = [java] Failed: [java] = [java] RuntimeL

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Carlos Rovira
"tests/rpc" is failing due to a service hosted in adobe services [1], so should deactivated it? (Peter said that if some test rely on some adobe service we should comment the test). The errors are like this: faultCode = "Server.Error.Request" faultDetail = "Unable to load WSDL. If currently onli

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Carlos Rovira
I just try test/ListDataEffects folder: ./mini_run.sh -createImages tests/ListDataEffects/ java] = [java] Passes: 6 [java] Fails: 0 [java] = So this folder is ok --

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Carlos Rovira
Hi Alex, as I see you and Peter was able to deal with Jose Barragan's patches vía github, I created this patch in the same way and create the JIRA ticket as well (both are referenced from one to another): JIRA ticket: https://issues.apache.org/jira/browse/FLEX-33180#comment-13442150 gihub patch:

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Cyrill Zadra
Couldn't give up :) and found finally the correct localX/localY . Patch file are attached to JIRA task https://issues.apache.org/jira/browse/FLEX-33173 "tests/Manager/DragManager" [java] = [java] Passes: 77 [java] Fails:

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-26 Thread Cyrill Zadra
Thanks for feedback.. I played around with localX/localY but no success. Isn't DragProxy only created once during one mouseMove transaction? Or is it every time a mouseEvent (type=move) is dispatched? cyrill On Fri, Aug 24, 2012 at 4:31 PM, Peter Ent wrote: > You should also make sure the area

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-24 Thread Peter Ent
You should also make sure the area is visible. I noticed on some DataGrid tests yesterday that the Canvas containing the DataGrids was too short. By making the container taller it exposed the DataGrid and the mouse events worked correctly (I'll put this into the Mustella wiki). This probably happen

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-24 Thread Alex Harui
I suspect that the tests need their mouse events localX/localY adjusted so the mouseMove actually causes a drag and the dragProxy to be created. On 8/24/12 6:51 AM, "Cyrill Zadra" wrote: > Hi peter > > Cool.. thanks for testing my patch. Well those errors I had at the end too. > But after few

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-24 Thread Cyrill Zadra
Hi peter Cool.. thanks for testing my patch. Well those errors I had at the end too. But after few hours investigation I couldn't find a way to get those tests working except if removed alle the waitTarget="mx.managers::DragManager.mx_internal:dragProxy" attributes. Always the first test step that

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-24 Thread Peter Ent
The `patch -p1 < Š..` command did the trick. The curl + patch gave me errors about not finding a file to patch. Nevertheless, the second command worked. That said, running Gave me these failures: [java] Managers/DragManager/Halo/DragManager_Cursors_RTL DragManager_Mirroring_copyCursor Failed

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-23 Thread Justin Mclean
Hi, What OS are you and what version of patch are you using? On OSX Lion with patch 2.5.8 both of these worked for me: curl https://issues.apache.org/jira/secure/attachment/12541538/0003-fixed-TileList-and-DragManager-tests-in-DragManager_.patch | patch -p1 patch -p1 < attachment/12541538/00

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-23 Thread Peter Ent
I tried that: patch -p1 ~/apache/patches/0003-fixed-TileList-and-DragManager-tests-in-DragManager_. patch . from the "flex" directory where "mustella" is a sub-directory. I got this error: patch: read error : Is a directory So I tried it without the "." and all this did was sit there, as i

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-22 Thread Justin Mclean
Hi, > svn patch 0003-fixed-TileList-and-DragManager-tests-in-DragManager_.patch . The patch is in git format which is slightly different to what svn supports. Try this instead "patch -p1 0003-fixed-TileList-and-DragManager-tests-in-DragManager_.patch". The -p1 will strip the first letter (ie t

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-22 Thread Alex Harui
I think there is just a patch command, something like patch p1 -F 0003-fixed.DragManager_.patch Just try patch --help at the command prompt and see what you get. On 8/22/12 1:11 PM, "Peter Ent" wrote: > Hi, > > I am getting the same error: > Skipped missing target: > 'b/mustella/test

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-22 Thread Peter Ent
Hi, I am getting the same error: Skipped missing target: 'b/mustella/tests/Managers/DragManager/Halo/DragManager_ComponentTests.mxml ' I have never used svn patch before and the docs aren't that helpful to me, although it seems pretty straightforward. Here's the command I am using. I am in the mu

Re: [jira] [Updated] (FLEX-33173) Mustella DragManager Patch

2012-08-22 Thread Peter Ent
OK. I will take a look at it today. --peter On 8/22/12 6:54 AM, "Cyrill Zadra (JIRA)" wrote: > > [ >https://issues.apache.org/jira/browse/FLEX-33173?page=com.atlassian.jira.p >lugin.system.issuetabpanels:all-tabpanel ] > >Cyrill Zadra updated FLEX-33173: > >