1. simgear/simgear_config.h.in should not be in CVS, as it is generated from 
configure.in and so gives conflicts on every update.

2. simgear/metar/Dcdmetar.cpp: function "static bool vrblVsby" is unused, so could 
profitably be removed or surrounded by "#if 0".  (Note that, being static, it can't 
possibly be used by anything outside that file.  Hence gcc -Wall warns about it.)

3. simgear/threads/SGThread.hxx: comma at end of enumeration list is warned about, so 
we ought to get rid of it:
diff -u -3 -p -r1.3 SGThread.hxx
--- simgear/threads/SGThread.hxx        11 Apr 2001 21:14:24 -0000      1.3
+++ simgear/threads/SGThread.hxx        5 Jun 2002 20:58:33 -0000
@@ -54,7 +54,7 @@ public:
     {
        CANCEL_DISABLE = 0,
        CANCEL_DEFERRED,
-       CANCEL_IMMEDIATE,
+       CANCEL_IMMEDIATE
     };
 public:


4. simgear/timing/geocoord.cxx: variable "nearest" is "possibly used un-initialised", 
according to GCC, so we ought to initialise it, even though I've checked that it is 
actually OK:
diff -u -3 -p -r1.3 geocoord.cxx
--- simgear/timing/geocoord.cxx 24 Mar 2001 03:20:47 -0000      1.3
+++ simgear/timing/geocoord.cxx 5 Jun 2002 20:58:34 -0000
@@ -80,7 +80,7 @@ GeoCoord* GeoCoordContainer::getNearest(
   sgVec3 first, secnd;
   float dist, maxDist=SG_MAX;
   sgSetVec3( first, ref.getX(), ref.getY(), ref.getZ());
-  GeoCoordVectorConstIterator i, nearest;
+  GeoCoordVectorConstIterator i, nearest = NULL;
   for (i = data.begin(); i != data.end(); i++)
     {
       sgSetVec3(secnd, (*i)->getX(), (*i)->getY(), (*i)->getZ());

5. simgear/xml/xmltok_impl.c: variable "open" is "possibly used un-initialised", 
according to GCC, so we ought to initialise it, even though I've checked that it is 
actually OK:
diff -u -3 -p -r1.1 xmltok_impl.c
--- simgear/xml/xmltok_impl.c   26 Jul 2000 19:17:46 -0000      1.1
+++ simgear/xml/xmltok_impl.c   5 Jun 2002 20:58:39 -0000
@@ -1391,7 +1391,7 @@ int PREFIX(getAtts)(const ENCODING *enc,
 {
   enum { other, inName, inValue } state = inName;
   int nAtts = 0;
-  int open;
+  int open = 0;

   for (ptr += MINBPC(enc);; ptr += MINBPC(enc)) {
     switch (BYTE_TYPE(enc, ptr)) {


- Julian

_______________________________________________
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel

Reply via email to