Re: [Flightgear-devel] Re: fix for exit crash

2006-03-07 Thread Jean-Yves Lefort
On Tue, 7 Mar 2006 09:39:31 +0100 Melchior FRANZ <[EMAIL PROTECTED]> wrote: > * Jean-Yves Lefort -- Tuesday 07 March 2006 09:30: > > Melchior FRANZ <[EMAIL PROTECTED]> wrote: > > > If it can'tbe done cleanly before the release, then we can still [...] > > > What about my solution? > > Oh, true.

[Flightgear-devel] Re: fix for exit crash

2006-03-07 Thread Melchior FRANZ
* Melchior FRANZ -- Tuesday 07 March 2006 09:39: > Still an ugly workaround, but the best of all so far. Committed, thanks. It's a workaround, but it's not ugly. If the thread can't get canceled cleanly, let it terminate itself. We can't expect canceling to work well on all platforms any time soon

[Flightgear-devel] Re: fix for exit crash

2006-03-07 Thread Melchior FRANZ
* Jean-Yves Lefort -- Tuesday 07 March 2006 09:30: > Melchior FRANZ <[EMAIL PROTECTED]> wrote: > > If it can'tbe done cleanly before the release, then we can still [...] > What about my solution? Oh, true. Still an ugly workaround, but the best of all so far. BTW: what about the other thread usin

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-07 Thread Jean-Yves Lefort
On Tue, 7 Mar 2006 08:07:00 +0100 Melchior FRANZ <[EMAIL PROTECTED]> wrote: > * Martin Spott -- Monday 06 March 2006 15:17: > > FreeBSD-5.3: > > > > Assertion failed: (status == 0), function ~SGMutex, file > > /opt/FlightGear/include/simgear/threads/SGThread.hxx, line 227. > > Abort (core dumped

[Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Melchior FRANZ
* Martin Spott -- Monday 06 March 2006 15:17: > FreeBSD-5.3: > > Assertion failed: (status == 0), function ~SGMutex, file > /opt/FlightGear/include/simgear/threads/SGThread.hxx, line 227. > Abort (core dumped) OK, that's enough proof. This definitely needs to be fixed. If it can't be done cleanl

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Martin Spott
Melchior FRANZ wrote: > * Jean-Yves Lefort -- Sunday 05 March 2006 03:06: >> The attached patch fixes a crash which occurs on exit. > > Anyone else seeing this "crash" (which really is a deliberate abort())? > Or is it a BSD feature? FreeBSD-5.3: Assertion failed: (status == 0), function ~SGMute

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Jean-Yves Lefort
On Mon, 6 Mar 2006 11:37:21 +0100 Melchior FRANZ <[EMAIL PROTECTED]> wrote: > * Jean-Yves Lefort -- Monday 06 March 2006 11:28: > > pthread_cancel() does cause the thread to exit, but the C++ > > destructors are not invoked. The SGGuard destructor can therefore > > not unlock the mutex. > > Whic

[Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Melchior FRANZ
* Jean-Yves Lefort -- Monday 06 March 2006 11:28: > pthread_cancel() does cause the thread to exit, but the C++ > destructors are not invoked. The SGGuard destructor can therefore > not unlock the mutex. Which destructor is not invoked (apart from the SGGuard one)? ~FGEnvironmentCtrl()? That woul

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Jean-Yves Lefort
On Mon, 6 Mar 2006 08:01:54 +0100 Melchior FRANZ <[EMAIL PROTECTED]> wrote: > > In the FGMetarEnvironmentCtrl destructor, thread->cancel() causes the > > following thread->join() call to return without actually waiting on > > the thread (btw, thread->cancel() does not cause the thread to exit). >

RE: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Vivian Meazza
Melchior FRANZ > > > I'm also getting the very annoying "... leaving my airspace ..." crash, > > which looks very similar. > > Can you post a backtrace for that? > It doesn't happen every time, and it isn't happening right now. The next time it does, I'll try to get a bt. V. --

[Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Melchior FRANZ
* Vivian Meazza -- Monday 06 March 2006 09:40: > I don't know if it is _this_ crash with SG and FG cvs_HEAD under Cygwin, but > I have been getting a segfault on exit for a little while now. So far as I > can see it is related to the recent ATC changes, not metar. No, then it is not the same crash

[Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Melchior FRANZ
* Erik Hofman -- Monday 06 March 2006 09:37: > I've seen this assertion failure at least once on IRIX. > I'm not all that certain I has all packages in sync though. There were two bugs, one of them an assertion bug in the destructor because of a locked (or rather over-unlocked) mutex. These were t

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread pigeon
A while ago AJ and I had the same crash with FG/SG cvs with multiplay. After some valgrinding I managed to get this errors, which also has something to do with things being freed in the destructor and got reference again further in another destructor. I get this report when I exit FG, see if this w

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Erik Hofman
Melchior FRANZ wrote: * Jean-Yves Lefort -- Sunday 05 March 2006 03:06: The attached patch fixes a crash which occurs on exit. Anyone else seeing this "crash" (which really is a deliberate abort())? Or is it a BSD feature? I've seen this assertion failure at least once on IRIX. I'm not all t

RE: [Flightgear-devel] Re: fix for exit crash

2006-03-06 Thread Vivian Meazza
Melchior FRANZ > > * Jean-Yves Lefort -- Sunday 05 March 2006 03:06: > > The attached patch fixes a crash which occurs on exit. > > Anyone else seeing this "crash" (which really is a deliberate abort())? > Or is it a BSD feature? I don't know if it is _this_ crash with SG and FG cvs_HEAD under

[Flightgear-devel] Re: fix for exit crash

2006-03-05 Thread Melchior FRANZ
* Jean-Yves Lefort -- Sunday 05 March 2006 03:06: > The attached patch fixes a crash which occurs on exit. Anyone else seeing this "crash" (which really is a deliberate abort())? Or is it a BSD feature? > In the FGMetarEnvironmentCtrl destructor, thread->cancel() causes the > following thread->

Re: [Flightgear-devel] Re: fix for exit crash

2006-03-05 Thread Jean-Yves Lefort
On Mon, 6 Mar 2006 01:28:50 +0100 Melchior FRANZ <[EMAIL PROTECTED]> wrote: > * Jean-Yves Lefort -- Sunday 05 March 2006 03:06: > > The attached patch fixes a crash which occurs on exit. > > > Assertion failed: (status == 0), function ~SGMutex, file > > /home/jylefort/test/simgear-head/include/si

[Flightgear-devel] Re: fix for exit crash

2006-03-05 Thread Melchior FRANZ
* Jean-Yves Lefort -- Sunday 05 March 2006 03:06: > The attached patch fixes a crash which occurs on exit. > Assertion failed: (status == 0), function ~SGMutex, file > /home/jylefort/test/simgear-head/include/simgear/threads/SGThread.hxx, line > 227. > Abort trap (core dumped) So it's not a c