Re: [Flightgear-devel] [Simgear-cvslogs] CVS: SimGear/simgear/math SGQuat.hxx, 1.11, 1.12
Frederic, However compiler.h isn't included into SGQuat.hxx, so I didn't realized that you had a patch in compiler.h. I am not to sure which headers should be included. So I prefered a local patch, here. Please feel free to fix it properly. Olaf ... left out fix for copysign for Microsoft Compiler This is redundant with a fix I already put in compiler.h - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Simgear-cvslogs] CVS: SimGear/simgear/math SGQuat.hxx, 1.11, 1.12
Selon Olaf Flebbe : Frederic, However compiler.h isn't included into SGQuat.hxx, so I didn't realized that you had a patch in compiler.h. I am not to sure which headers should be included. So I prefered a local patch, here. Please feel free to fix it properly. Olaf ... left out fix for copysign for Microsoft Compiler This is redundant with a fix I already put in compiler.h For me, including the define in compiler.h was all that was needed. I don't see a problem without it in SGQuat.hxx. We are compiling the same files, aren't we ? If it is a problem for you, please post the error. I would like to understand the issue. Thanks, -Fred -- Frédéric Bouvier http://frfoto.free.fr Photo gallery - album photo http://www.fotolia.fr/p/2278/partner/2278 Other photo gallery http://fgsd.sourceforge.net/ FlightGear Scenery Designer - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Simgear-cvslogs] CVS: SimGear/simgear/math SGQuat.hxx, 1.11, 1.12
Selon Frederic Bouvier : Selon Olaf Flebbe : Frederic, However compiler.h isn't included into SGQuat.hxx, so I didn't realized that you had a patch in compiler.h. I am not to sure which headers should be included. So I prefered a local patch, here. Please feel free to fix it properly. Olaf ... left out fix for copysign for Microsoft Compiler This is redundant with a fix I already put in compiler.h For me, including the define in compiler.h was all that was needed. I don't see a problem without it in SGQuat.hxx. We are compiling the same files, aren't we ? If it is a problem for you, please post the error. I would like to understand the issue. Ok, maybe we are out of sync in this discussion. I already removed the copysign definition in favor of a more centralized place: compiler.h that already has definitions for isnan and vsnprintf. Tell me if it still work for you -Fred -- Frédéric Bouvier http://frfoto.free.fr Photo gallery - album photo http://www.fotolia.fr/p/2278/partner/2278 Other photo gallery http://fgsd.sourceforge.net/ FlightGear Scenery Designer - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Simgear-cvslogs] CVS: SimGear/simgear/math SGQuat.hxx, 1.11, 1.12
Fred, If it is a problem for you, please post the error. I would like to understand the issue. I doublechecked and looked at the CVS history, time stamps of emails... I created a patch and forgot to send them immediatly to Mathias to be included into the release. In the meantime you fixed it at a different place in source. I did an update, everything worked o.k. so I asked Mathias to commit the diff. I did a recompile, the _copysign is not needed any more in SGQuat.hxx. Please feel free to remove. Olaf BTW: Do you have an OSG build running? - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [Simgear-cvslogs] CVS: SimGear/simgear/math SGQuat.hxx, 1.11, 1.12
Selon Mathias Froehlich : Update of /var/cvs/SimGear-0.3/SimGear/simgear/math In directory baron:/tmp/cvs-serv15898/simgear/math Modified Files: SGQuat.hxx Log Message: Modified Files: simgear/scene/util/SGDebugDrawCallback.hxx simgear/math/SGQuat.hxx: Olaf Flebbe: Make it compile on some more win32 variants. Index: SGQuat.hxx === RCS file: /var/cvs/SimGear-0.3/SimGear/simgear/math/SGQuat.hxx,v retrieving revision 1.11 retrieving revision 1.12 diff -C 2 -r1.11 -r1.12 *** SGQuat.hxx1 Nov 2006 21:25:21 - 1.11 --- SGQuat.hxx7 Nov 2006 05:46:26 - 1.12 *** *** 27,30 --- 27,35 #endif + // for microsoft compiler + #ifdef _MSC_VER + #define copysign _copysign + #endif + #include osg/Quat This is redundant with a fix I already put in compiler.h -Fred -- Frédéric Bouvier http://frfoto.free.fr Photo gallery - album photo http://www.fotolia.fr/p/2278/partner/2278 Other photo gallery http://fgsd.sourceforge.net/ FlightGear Scenery Designer - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
