Re: [Flightgear-devel] Compiler Warnings = Merge Request
Hi, On 2010-09-28, at 01:11, Csaba Halász wrote: I fixed the strict-aliasing issues reported by GCC 4.4.1. Affects the generic.cxx and multiplaymgr.cxx modules. Unfortunately the trick with the union in multiplaymgr.cxx is not standard C, as far as I know. well, unions are ANSI C. I guess you mean the write to one union member and read another member bit isn't standard? Even if it proves nothing, there are already several places using unions for this purpose. The multiplayer module also relies on it: tiny_xdr.cxx uses several unions to convert floats and doubles. Likewise, unions u32 and u64 are used for this in generic.cxx. So, at least the trick isn't new to FlightGear :-). But I noticed the entire FGMultiplayMgr::MsgBuf is a union already. So I removed the introduction of a new one, reducing the patch for multiplaymgr to a minimum (updated http://gitorious.org/fg/flightgear/merge_requests/7 ). cheers, Thorsten -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Compiler Warnings = Merge Request
Hi, I fixed the strict-aliasing issues reported by GCC 4.4.1. Affects the generic.cxx and multiplaymgr.cxx modules. I created a merge request (let me know if you preferred patches): http://gitorious.org/fg/flightgear/merge_requests/7 cheers, Thorsten -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Compiler Warnings = Merge Request
On Tue, Sep 28, 2010 at 12:21 AM, ThorstenB bre...@gmail.com wrote: Hi, I fixed the strict-aliasing issues reported by GCC 4.4.1. Affects the generic.cxx and multiplaymgr.cxx modules. Unfortunately the trick with the union in multiplaymgr.cxx is not standard C, as far as I know. -- Csaba/Jester -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
