Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-12 Thread Torsten Dreyer
But you have broken my patch! :) Apologies! It's been a busy week and I tried to commit smart fixes between long work-days. Obviously not a good idea ;-) Also, Anders pointed out that more tanks may be needed even if they are not (yet) in the property tree, so ultimately the FDM should be

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-12 Thread Torsten Dreyer
That was not my point. I was talking about the Nasal error. Nasal runtime error: vector index 7 out of bounds (size: 7) at /wrklvm/FlightGear/FlightGear_CVS/data/Aircraft/Boeing314/Nasal/Boeing314-f uel.nas, line 79 That should be fixed. However, the version in GIT is broken due to a

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-12 Thread Jon S. Berndt
Hi Bertrand, I am currently working on a more generic solution to the issue based on your patch. Currently we have at least three different places within FlightGear calculating tank contents and converting them between different units. The idea is to have a TankProperties class

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-12 Thread Torsten Dreyer
Hi Bertrand, I am currently working on a more generic solution to the issue based on your patch. Currently we have at least three different places within FlightGear calculating tank contents and converting them between different units. The idea is to have a TankProperties class

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-10 Thread henri orange
That was not my point. I was talking about the Nasal error. Nasal runtime error: vector index 7 out of bounds (size: 7) at /wrklvm/FlightGear/FlightGear_CVS/data/Aircraft/Boeing314/Nasal/Boeing314-fuel.nas, line 79 called from:

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-10 Thread Csaba Halász
On Thu, Feb 10, 2011 at 3:21 PM, henri orange hohora...@gmail.com wrote: That was not my point. I was talking about the Nasal error. I know. I just pointed out that the GIT version is broken anyway. BUT working around the missing file, it DOES now fly, without the fuel nasal error. --

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-08 Thread Torsten Dreyer
And that is because of the hardcoded default of 8 fuel tanks. Attached patch makes sure at least the existing tanks are covered by the properties. Thanks for spotting this. I was naive enough to think no aircraft ever has more then eight tanks. Now TankProperties are created for every

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-08 Thread henri orange
Will it solved the Boeing314 issue ? 2011/2/8 Torsten Dreyer tors...@t3r.de And that is because of the hardcoded default of 8 fuel tanks. Attached patch makes sure at least the existing tanks are covered by the properties. Thanks for spotting this. I was naive enough to think no

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-08 Thread Csaba Halász
On Tue, Feb 8, 2011 at 9:27 PM, Torsten Dreyer tors...@t3r.de wrote: And that is because of the hardcoded default of 8 fuel tanks. Attached patch makes sure at least the existing tanks are covered by the properties. Thanks for spotting this. I was naive enough to think no aircraft ever has

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-08 Thread Csaba Halász
On Tue, Feb 8, 2011 at 10:05 PM, henri orange hohora...@gmail.com wrote: Will it solved the Boeing314 issue ? The Boeing314 in GIT doesn't even get that far, it is missing a file Nasal/Boeing314-limits.xml Commenting the reference out, the aircraft at least takes off. -- Csaba/Jester

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-07 Thread henri orange
Hello, Beware that version, break the tanks system of Boeing 314 Here the Nasal error Nasal runtime error: vector index 7 out of bounds (size: 7) at /wrklvm/FlightGear/FlightGear_CVS/data/Aircraft/Boeing314/Nasal/Boeing314-fuel.nas, line 79 called from:

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Bertrand Coconnier
2011/1/30 Bertrand Coconnier bcoco...@gmail.com: 2011/1/29 Ron Jensen w...@jentronics.com: +      double fuelDensity = Propulsion-GetTank(i)-GetDensity(); ( ... ) + Propulsion-GetTank(i)-GetContents() / fuelDensity); Should we guard against GetDensity() returning 0? Correct. Please

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Torsten Dreyer
Hi FG developers, Since no further comments have been made, is there any chance to see this patch committed in Flight Gear ? In case you would have additional comments or questions before committing, I am of course open to answer them Cheers, Bertrand. Hi Bertrand, I am currently

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Bertrand Coconnier
2011/2/6 Torsten Dreyer tors...@t3r.de: I am currently working on a more generic solution to the issue based on your patch. Currently we have at least three different places within FlightGear calculating tank contents and converting them between different units. The idea is to have a

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread James Turner
On 6 Feb 2011, at 14:34, Torsten Dreyer wrote: I'm curently testing various aircraft on Windows and Linux and I hope to get this commited later today. Need to update the MSVC90 project file? http://flightgear.simpits.org:8080/job/FlightGear-next-Win/395/ James

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Bertrand Coconnier
2011/2/6 Torsten Dreyer tors...@t3r.de: I'm curently testing various aircraft on Windows and Linux and I hope to get this commited later today. Torsten, I have checked your code and it breaks the previous behaviour for JSBSim. Your code is overwriting JSBSim values during initialization, I

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Torsten Dreyer
Need to update the MSVC90 project file? Yep - that's done. All builds should be green again. This patch provides consistent tank properties for /consumables/fuel/tank[0..7]. The handled properties under each branch are * level-kg (fuel level in kilogramm) * density-kgpm3 (fuel density in kg

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Bertrand Coconnier
2011/2/6 Torsten Dreyer tors...@t3r.de: I tried the few JSBSim and YASim aircraft that I'm able to handle, please report if I broke anything. Have you read my previous e-mail ? I attached a patch because JSBSim fuel calcs are broken (tested aircraft is p51d). All P51d tank capacities, levels

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Csaba Halász
On Sun, Feb 6, 2011 at 9:24 PM, Bertrand Coconnier bcoco...@gmail.com wrote: 2011/2/6 Torsten Dreyer tors...@t3r.de: I tried the few JSBSim and YASim aircraft that I'm able to handle, please report if I broke anything. Have you read my previous e-mail ? I attached a patch because JSBSim

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Csaba Halász
On Sun, Feb 6, 2011 at 9:35 PM, Csaba Halász csaba.hal...@gmail.com wrote: But the Concorde still doesn't fly, it now runs out of fuel after a few seconds. Still investigating that issue. And that is because of the hardcoded default of 8 fuel tanks. Attached patch makes sure at least the

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Torsten Dreyer
I have checked your code and it breaks the previous behaviour for JSBSim. Your code is overwriting JSBSim values during initialization, I would rather do it the other way around and make JSBSim overwrite FlightGear default values. Especially because the capacity of all the tanks is now set to

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-02-06 Thread Hal V. Engel
On Sunday, February 06, 2011 01:13:28 PM Torsten Dreyer wrote: I have checked your code and it breaks the previous behaviour for JSBSim. Your code is overwriting JSBSim values during initialization, I would rather do it the other way around and make JSBSim overwrite FlightGear default

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-01-30 Thread Bertrand Coconnier
2011/1/29 Ron Jensen w...@jentronics.com: +      double fuelDensity = Propulsion-GetTank(i)-GetDensity(); ( ... ) + Propulsion-GetTank(i)-GetContents() / fuelDensity); Should we guard against GetDensity() returning 0? Correct. Please find an updated version of the patch that uses the

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-01-29 Thread Bertrand Coconnier
2011/1/28 Hal V. Engel hven...@gmail.com: A thread was opened on the forum about how the C172P appeared to be incorrectly calculating the amount of fuel in gallons based on the weight of the fuel.  It appears that the conversion is using 6.6 lbs/gal when it should be using something close to

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-01-29 Thread Bertrand Coconnier
A better improved patch that supersedes the previous FuelDensity.diff I sent to this list. This one takes /consumables/fuel/tank[n]/density-ppg into account in the calcs. Cheers, Bertrand. 2011/1/29 Bertrand Coconnier bcoco...@gmail.com: 2011/1/28 Hal V. Engel hven...@gmail.com: A thread was

Re: [Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-01-29 Thread Ron Jensen
On Saturday 29 January 2011 07:36:54 Bertrand Coconnier wrote: 2011/1/28 Hal V. Engel hven...@gmail.com: A thread was opened on the forum about how the C172P appeared to be incorrectly calculating the amount of fuel in gallons based on the weight of the fuel.  It appears that the conversion

[Flightgear-devel] Incorrect conversion used for lbs to gallon of fuel

2011-01-28 Thread Hal V. Engel
A thread was opened on the forum about how the C172P appeared to be incorrectly calculating the amount of fuel in gallons based on the weight of the fuel. It appears that the conversion is using 6.6 lbs/gal when it should be using something close to 6.0. That is