John Denker wrote:
On 08/22/2008 03:47 AM, Tim Moore wrote:
John Denker wrote:
As of 08/18/2008 04:45 PM, I had done exactly what I was asked to do.
I suppose I wasn't specific enough. I meant that would be helpful for the
branches in your Sport Model repository to be rebased onto or merged with
Pigeon's official ones. Unless I'm pointing at the wrong repos, I haven't
seen
any change there.
These patches are relative to the latest and greatest source from Pigeon's
git
archive, current as of a few minutes ago.
Was it in fact helpful?
Of course, there's certainly more to talk about when a patch is based on the
current code. I'm sorry I haven't joined in (or really processed) the recent
discussion of textranslate; I've had my head down in other stuff.
Allow me to be more specific:
I gave you the opportunity to persuade me that re-basing the patches
would be helpful ... that it would be something other than a completely
futile waste of my time.
I can't imagine why rebasing the Sport Model patches would be a futile waste of
time. What do you expect people to do with the Sport Model patches? Run a
year-old version of FlightGear? Try to integrate patches based on out-of-date
sources into their own trees?
You chose the example of textranslate step and scroll. It probably
wouldn't have been my first choice, but it is the example on the table,
and will serve the purpose. Think of it as a test-flight.
Indeed. I chose this patch because it is the earliest one in your Sport Model
sg
repository. I don't have a great stake in how texture animation of instruments
works but yeah, it would be nice if it was correct. And it looks like there's
some good stuff in the whole of your patches, so it would be nice to start
merging it in. I'm not going to look at anything unless it's based off the
current sources, so I started rebasing your sg tree myself. This textranslate
patch, the very first one, has a serious merge conflict. I could plow through
all your patches and try to finish a local rebase of your stuff, but there are
very likely more merge conflicts lurking there, and as the patch author you are
in a much better position than I to resolve these conflicts.
If you ask me to re-base this patch and then don't even look at it, I
am *not* persuaded to re-base any of the other patches.
I have in fact looked it, in both it's new and old versions, and had
discussions
about it on IRC with at least one of your interlocutors from the discussion
last
year. I meant by my comment about lack of time that I didn't have an opinion
yet
and hadn't contributed to the new email discussion. That being said, I do not
do
your or anyone else's bidding in terms of committing patches in any particular
time frame. I'm not sure if/when I'd commit your textranslate patch, or if
others would be committed first, and what the final form would be.
There is a multi-year track record of patches not being looked at, and
other bad behavior. If anybody wants to persuade me that things are
better now, I'm waiting to be persuaded. The ball's in your court.
No. Your patches should have more value to you merged into the mainline than
apart; if not, then one really has to question what value they have at all. The
fact that you've put them in a git repository should make them easy to evaluate
on their technical merits and integrate without politics. If they are in a form
suitable for easy review and merging -- that is, based on current sources --
then I can look at them, merge those that are obviously right, and persuade
others who know the subject area better than me to give them another look.
I'm sorry if you are mad at the reception your patches received in the past,
but
I'm not inclined to play open-source therapist.
Tim
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
