Re: [Flightgear-devel] Random instrument failures and altimeter gremlins patch

2007-07-07 Thread Stuart Buchanan 

--- Melchior FRANZ wrote:
 * Stuart Buchanan -- Tuesday 03 July 2007:
  The included XML files replace those in the gui/dialogs directory,
 while
  gremlins.nas should be put in the Nasal directory.
 
 gremlins.nas?  Please not funny names in $FG_ROOT/Nasal/. These
 are code files, and so far all of them were called after their purpose.
 This makes it easier for all to see what they are about.
 
 What I don't really understand is why local variables need to be ii and
 nnn. What's wrong with just i and n, like everyone else uses? Or is
 exactly *that* the problem?
 
   for (ii = 0; ii  5; ii+=1){
   ...
   nnn = props.globals.getNode(feat ~ /serviceable, 1);
   if (nnn.getValue() == nil) {
 nnn.setBoolValue(1);

I've fixed both these issues. The Nasal file is now called failures.nas,
and I've shortened the variables as requested. I've also gotten rid of the
height and width settings on the dialog boxes.

New version of the patch, along with documentation available from

http://www.nanjika.co.uk/flightgear/failures.tar.gz

Could someone please commit this to CVS?

Best Regards to all,

-Stuart



  ___
Yahoo! Answers - Got a question? Someone out there knows the answer. Try it
now.
http://uk.answers.yahoo.com/ 

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Re: [Flightgear-devel] Random instrument failures and altimeter gremlins patch

2007-07-04 Thread leee 
On Tuesday 03 July 2007 22:58, Melchior FRANZ wrote:
 * Stuart Buchanan -- Tuesday 03 July 2007:
  The included XML files replace those in the gui/dialogs directory, while
  gremlins.nas should be put in the Nasal directory.

 gremlins.nas?  Please not funny names in $FG_ROOT/Nasal/. These
 are code files, and so far all of them were called after their purpose.
 This makes it easier for all to see what they are about.

 What I don't really understand is why local variables need to be ii and
 nnn. What's wrong with just i and n, like everyone else uses? Or is
 exactly *that* the problem?

   for (ii = 0; ii  5; ii+=1){
   ...
   nnn = props.globals.getNode(feat ~ /serviceable, 1);
   if (nnn.getValue() == nil) {
 nnn.setBoolValue(1);

 Or is nnn an acronym for something?

 m.

Is it really worth making an issue over two and three character local variable 
names?

LeeE


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Re: [Flightgear-devel] Random instrument failures and altimeter gremlins patch

2007-07-04 Thread Melchior FRANZ 
* leee -- Wednesday 04 July 2007:
 Is it really worth making an issue over two and three character
 local variable names?

My comments weren't made as a random list subscriber, but as
someone who was about to commit the stuff, and would have liked
some things changed first. And yes, that also concerns coding
style. The nnn/ttt/... notation is ugly. I said so, and that's it.

These were only *my* prerequisites, not general, official ones.
If mine aren't met, then I'm just not available for committing.
The one who commits code is, after all, responsible for its
quality, not the one who wrote it.

My objections were dismissed by the submitter, so my involvement
in this matter is hereby finished. There are 20 other people with
commit permissions. They should have some fun, too. There are surely
some who don't have any conditions. Dump into aircraft directories
whatever you like. Just keep the common space clean, please.  :-}

m.


-- 
You don't seem to understand what being a maintainer means.
It means saying no to crap.  -- Linus TORVALDS

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

[Flightgear-devel] Random instrument failures and altimeter gremlins patch

2007-07-03 Thread Stuart Buchanan 
Hi All,

John Denker and I have been working on randomized failure modes for the
Instrument Failure and System Failure dialogs.

- You can now indicate the Mean Time Between Failure and Mean Cycles
Between Failure for the various standard instruments and systems in the
Instrument Failure and System Failure dialogs.
- Additionally, by settings a property (no GUI currently) you can cause
QNH to vary on reset, forcing the pilot to check ATIS/AWOS.

Patch available from http://www.nanjika.co.uk/flightgear/gremlins.tar.gz.

The included XML files replace those in the gui/dialogs directory, while
gremlins.nas should be put in the Nasal directory.

Now you can _really_ spice up your instrument approaches!

-Stuart




  ___ 
Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for
your free account today 
http://uk.rd.yahoo.com/evt=44106/*http://uk.docs.yahoo.com/mail/winter07.html 

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Re: [Flightgear-devel] Random instrument failures and altimeter gremlins patch

2007-07-03 Thread Melchior FRANZ 
* Stuart Buchanan -- Tuesday 03 July 2007:
 The included XML files replace those in the gui/dialogs directory, while
 gremlins.nas should be put in the Nasal directory.

gremlins.nas?  Please not funny names in $FG_ROOT/Nasal/. These
are code files, and so far all of them were called after their purpose.
This makes it easier for all to see what they are about.

What I don't really understand is why local variables need to be ii and
nnn. What's wrong with just i and n, like everyone else uses? Or is
exactly *that* the problem?

  for (ii = 0; ii  5; ii+=1){
  ...
  nnn = props.globals.getNode(feat ~ /serviceable, 1);
  if (nnn.getValue() == nil) {
nnn.setBoolValue(1);

Or is nnn an acronym for something?

m.

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel