Re: [Flightgear-devel] Patch for metar.exe for windows

2012-07-28 Thread Geoff McLane
Hi Chris, You are right to question why 1.1, but I guess since SG/FG family mainly follows POSIX (Berkely/BSD) sockets, no Microsoft extensions are used or needed, so requesting 1.1 seems ok, so this is deliberate... In all code cases checked, we do however include WinSock2.h, except in some

Re: [Flightgear-devel] Patch for metar.exe for windows

2012-07-27 Thread James Turner
On 27 Jul 2012, at 16:37, Geoff McLane wrote: For a long, LONG time the small utility program metar.exe has failed to work in windows... It turns out WSAStartup() is NOT called, thus the HTTP request always fails... Applied this simple patch below, and all is well ;=)) Hope this

Re: [Flightgear-devel] Patch for metar.exe for windows

2012-07-27 Thread Geoff McLane
On Fri, 2012-07-27 at 17:39 +0100, James Turner wrote: On 27 Jul 2012, at 16:37, Geoff McLane wrote: For a long, LONG time the small utility program metar.exe has failed to work in windows... It turns out WSAStartup() is NOT called, thus the HTTP request always fails...

Re: [Flightgear-devel] Patch for metar.exe for windows

2012-07-27 Thread Chris Forbes
Geoff, your patch is asking for the quirky old win95-era winsock1.1. Is this intentional? WSACancelBlockingCall and friends don't exist in modern winsock. -- Chris On Sat, Jul 28, 2012 at 5:03 AM, Geoff McLane ubu...@geoffair.info wrote: On Fri, 2012-07-27 at 17:39 +0100, James Turner wrote: