Re: [Flightgear-devel] using std::

2008-07-31 Thread Tim Moore
Erik Hofman wrote: James Turner wrote: I think this is a good example of why 'using std::xxx' is potentially problematic in headers (especially public library headers, i.e Simgear), but fine in sources. So if I'm doing future cleanups, that's the approach I'd take - remove 'using'

Re: [Flightgear-devel] using std::

2008-07-31 Thread Erik Hofman
Tim Moore wrote: To add my two cents: I mostly favor putting using declarations at the top of source files instead of using namespace qualifiers in the code. On the other hand, I would probably use the namespace qualifer explicitly if the symbol in question is somewhat obscure, to give

Re: [Flightgear-devel] using std::

2008-07-30 Thread James Turner
On 30 Jul 2008, at 11:29, Erik Hofman wrote: To continue this discussion a bit (please add your comments) James an I had a short discussion about using std::string (for example) everywhere in the file or using using std::string; at the beginning. James pointed out that the suing std::

Re: [Flightgear-devel] using std::

2008-07-30 Thread Melchior FRANZ
* Erik Hofman -- Wednesday 30 July 2008: To continue this discussion a bit (please add your comments) James an I had a short discussion about using std::string (for example) everywhere in the file or using using std::string; at the beginning. I think this shouldn't be a policy question at

Re: [Flightgear-devel] using std::

2008-07-30 Thread Erik Hofman
Melchior FRANZ wrote: * Erik Hofman -- Wednesday 30 July 2008: To continue this discussion a bit (please add your comments) James an I had a short discussion about using std::string (for example) everywhere in the file or using using std::string; at the beginning. I think this shouldn't

Re: [Flightgear-devel] using std::

2008-07-30 Thread Melchior FRANZ
* Erik Hofman -- Wednesday 30 July 2008: Melchior FRANZ wrote: * Erik Hofman -- Wednesday 30 July 2008: IOW: Leave it to the developer. Well I got some patches from James that turned 'using std::' into std::, hence the question. Yes, I undestood the situation and the question perfectly

Re: [Flightgear-devel] using std::

2008-07-30 Thread James Turner
On 30 Jul 2008, at 13:23, Melchior FRANZ wrote: Actually, I think that putting std:: at every reference is not preferable, as in 99% of the cases we mean std::string, and in 100% we mean std::cout, so the prefix is basically redundant noise. Do we actually have more than one or two cases

Re: [Flightgear-devel] using std::

2008-07-30 Thread Erik Hofman
James Turner wrote: I think this is a good example of why 'using std::xxx' is potentially problematic in headers (especially public library headers, i.e Simgear), but fine in sources. So if I'm doing future cleanups, that's the approach I'd take - remove 'using' from headers, and add it

Re: [Flightgear-devel] using std::

2008-07-30 Thread Melchior FRANZ
* Melchior FRANZ -- Wednesday 30 July 2008: Yes, I undestood the situation and the question perfectly well. Argh, no, I didn't. I missed the headers part. Of course I agree on that -- that's evil. Sorry for the redundant noise then. ;-) m.