On 15/01/11 09:50, Denton Thomas wrote:
I should have suggested removing a couple lines, however -
XFree() must happen at the end of fl_init_xim() whether or not the
if condition fails at 564, so the new/final XFree() call is basically
replacing line 567. I suggest we cut the XFree()
Will do. I can't get the weekly (8276) for a test right now,
though - looks like the domain is in transition ... and
caught due to MLK day.
I assume no one else can get a download right now, either?
The svn appears to be working OK for me - the latest changes will likely
not be in the
On 17.01.2011 11:42, Denton Thomas wrote:
Will do. I can't get the weekly (8276) for a test right now, though - looks
like the domain is in transition ... and caught due to MLK day.
It's working (again) for me. There were DNS problems last Saturday,
but they are fixed at least since Sunday
On 17.01.2011 11:42, Denton Thomas wrote:
Will do. I can't get the weekly (8276) for a test right now, though - looks
like the domain is in transition ... and caught due to MLK day.
It's working (again) for me. There were DNS problems last Saturday,
but they are fixed at least since
On 14/01/11 13:22, Denton Thomas wrote:
Agreed, setting to NULL at declaration is pointless! Line 546 is
fine.
Also agreed that it is smart to check xim_styles before use, and to
set it to NULL after. The xlib doc does not specify whether XFree
will or won't set incoming values to
On 15/01/11 09:50, Denton Thomas wrote:
I should have suggested removing a couple lines, however -
XFree() must happen at the end of fl_init_xim() whether or not the
if condition fails at 564, so the new/final XFree() call is basically
replacing line 567. I suggest we cut the XFree() at 567
Using: fltk-1.3.x-r8276 / Linux 2.6.33.3 (tinycore) on i686 / gcc 4.4.3
Found via Valgrind and a one-button hello program. In Fl_x.cxx, fl_init_xim()
allocates an XIM object using a call to libx11. fl_init_xim() only deallocates
that object in some cases, rather than in all. It looks like the
Found via Valgrind and a one-button hello program. In
Fl_x.cxx, fl_init_xim() allocates an XIM object using a call
to libx11. fl_init_xim() only deallocates that object in some
cases, rather than in all. It looks like the object is not
needed after fl_ini_xim(), so it should be
Found via Valgrind and a one-button hello program. In=20
Fl_x.cxx, fl_init_xim() allocates an XIM object using a call=20
to libx11. fl_init_xim() only deallocates that object in some=20
cases, rather than in all. It looks like the object is not=20
needed after fl_ini_xim(), so it should
On 14/01/11 13:22, Denton Thomas wrote:
Agreed, setting to NULL at declaration is pointless! Line 546 is
fine.
Also agreed that it is smart to check xim_styles before use, and to
set it to NULL after. The xlib doc does not specify whether XFree
will or won't set incoming values to NULL.
10 matches
Mail list logo
