Re: [fltk.development] Fl_Input_Choice suggestions

2011-07-22 Thread Michael Sweet
On Jul 20, 2011, at 12:15 AM, Greg Ercolano wrote: Would like to suggest adding a few things to Fl_Input_Choice: 1) Change the existing method: void add(const char *s) { menu_-add(s); } to instead: int add(const char *s) { return(menu_-add(s)); }

Re: [fltk.development] Fl_Input_Choice suggestions

2011-07-20 Thread MacArthur, Ian (SELEX GALILEO, UK)
These sound like useful additions to me... A few questions: a) Does (1) break the ABI (by changing the return value from void to int)? I think it does, but I am usually wrong about ABI stuff.. Pretty sure the others would have no impact. I think adding new methods is OK. (But

Re: [fltk.development] Fl_Input_Choice suggestions

2011-07-20 Thread Albrecht Schlosser
On 20.07.2011 11:11, MacArthur, Ian (SELEX GALILEO, UK) wrote: These sound like useful additions to me... A few questions: a) Does (1) break the ABI (by changing the return value from void to int)? I think it does, but I am usually wrong about ABI stuff.. Yes, I'm pretty sure this

Re: [fltk.development] Fl_Input_Choice suggestions

2011-07-20 Thread Greg Ercolano
On 07/20/11 02:11, MacArthur, Ian (SELEX GALILEO, UK) wrote: Pretty sure the others would have no impact. I think adding new methods is OK. (But see above!) Does it change the size of the class though? No changes in size, just adding code. Changing the return value

[fltk.development] Fl_Input_Choice suggestions

2011-07-19 Thread Greg Ercolano
Would like to suggest adding a few things to Fl_Input_Choice: 1) Change the existing method: void add(const char *s) { menu_-add(s); } to instead: int add(const char *s) { return(menu_-add(s)); } This corrects an omission, allowing the user to access