Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-11 Thread jimmy
Some more thoughts... --- On Thu, 2/10/11, David Henningsson wrote: > 2) The SF2 spec - which Pedro quoted - says that sf2 bank > 0-127 is > melodic and 128 is drums. So there is no "SFX Voice" in the > SF2 > standard, and no "SFX Kit" either. So what do we do with > it? Currently, > we ig

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-11 Thread Pedro Lopez-Cabanillas
On Friday 11 February 2011, jimmy wrote: > > Oops, sent with wrong subject line, before I finished. I wrote more beyond > last message, so read this message instead of last. > > > > --- On Thu, 2/10/11, "Pedro Lopez-Cabanillas" > wrote: > > > > So bank numbers above 128 usually make no sen

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread David Henningsson
On 2011-02-10 22:51, jimmy wrote: --- On Thu, 2/10/11, David Henningsson wrote: Basically the problem is that Soundfont files can have bank numbers up to 128 only, and that bank numbers 0-127 are melodic and bank 128 is percussion. At least that's the way SWAMI works. I checked Unison.sf2,

[fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread jimmy
Oops, sent with wrong subject line, before I finished. I wrote more beyond last message, so read this message instead of last. --- On Thu, 2/10/11, "Pedro Lopez-Cabanillas" wrote: > > So bank numbers above 128 usually make no sense, which > is why MSB is > > ignored for XG (and why MMA st

[fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread jimmy
--- On Sat, 5 Feb 2011, "Pedro Lopez-Cabanillas" wrote: > > And to the rest of you - this bank select handling > seems to be a never > > ending debate, and it's not my area of expertise, so > let me know if this > > change screwed something up for you. > > Looks OK, and also works fine in m

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread jimmy
--- On Thu, 2/10/11, David Henningsson wrote: > So bank numbers above 128 usually make no sense, which is > why MSB is > ignored for XG (and why MMA style is not the default...). > We're kind of > stuck between sf2's standard and XG's standard, and need to > figure out > how to mediate betwe

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread jimmy
--- On Thu, 2/10/11, David Henningsson wrote: > > Basically the problem is that Soundfont files can have bank > numbers up > to 128 only, and that bank numbers 0-127 are melodic and > bank 128 is > percussion. At least that's the way SWAMI works. I checked > Unison.sf2, > and it follows this

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread Pedro Lopez-Cabanillas
On Thursday 10 February 2011, David Henningsson wrote: > On 2011-02-10 02:45, jimmy wrote: > > > > > >> Hey jimmy, > >> > >> Thanks for the research. I've committed the patch now (with > >> some trivial > >> changes). Thanks for your contribution! > >> > >> And to the rest of you - this bank select

Re: [fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-10 Thread David Henningsson
On 2011-02-10 02:45, jimmy wrote: Hey jimmy, Thanks for the research. I've committed the patch now (with some trivial changes). Thanks for your contribution! And to the rest of you - this bank select handling seems to be a never ending debate, and it's not my area of expertise, so let me kno

[fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-09 Thread jimmy
> Hey jimmy, > > Thanks for the research. I've committed the patch now (with > some trivial > changes). Thanks for your contribution! > > And to the rest of you - this bank select handling seems to > be a never > ending debate, and it's not my area of expertise, so let me > know if this > ch

[fluid-dev] Re: Patch for channel_type, also XG drum-channel autoswitch

2011-02-07 Thread jimmy
--- On Sun, 2/6/11, "Pedro Lopez-Cabanillas" wrote: > I've > never been a XG user, so changeset #340 included several > TODOs and FIXMEs that this patch has finally addressed. But > there is still one (FIXME: pending implementation of SYSEX > midi mode changes) that somebody has to work on, an