RE: Proposal to remove contrast themes for jQuery UI

[Justin Obara]

Hi Everyone,

Thanks for the feedback. I’ll be removing the jQuery UI contrast themes as
part of my work for https://issues.fluidproject.org/browse/FLUID-6297

Thanks
Justin


On July 17, 2018 at 11:40:11 AM, Moss, Gregor (gm...@ocadu.ca) wrote:

+1 from me as well, though my familiarity with the context is basically
zero outside of what you’ve mentioned in your email, Justin. I think if
there’s any level of certainty that these are no longer being used and will
not be used in the future, then it is cruft and best removed. If they are
required again in the future, it can be added. Just my $0.02 



Cheers,

Gregor



*From:* fluid-work  *On Behalf
Of *Harnum,
Alan
*Sent:* July 11, 2018 14:39
*To:* Justin Obara ; Fluid Work <
fluid-w...@fluidproject.org>
*Subject:* Re: Proposal to remove contrast themes for jQuery UI



+1



*From: *fluid-work  on behalf of
Justin Obara 
*Date: *Wednesday, July 11, 2018 at 2:38 PM
*To: *Fluid Work 
*Subject: *Proposal to remove contrast themes for jQuery UI



I’ve been looking at adding some additional low contrast themes for the
contrast preference in UI Options (See: FLUID-6297
<https://issues.fluidproject.org/browse/FLUID-6297> . In the process of
working on that I noticed that the jQuery UI contrast themes
<https://github.com/fluid-project/infusion/tree/master/src/lib/jquery/ui/css>
are
not actually being used. There were several references to them for use by
the prefs framework panels/adjusters; however they were not actually
required there. They most likely fell out of need when we switched off of
the jQuery UI Sliders in favour of our own native sliders and steppers.



Originally the jQuery UI contrast themes were provided as a way to add
jQuery UI specific styling created with their themeroller
<https://jqueryui.com/themeroller/> tool. Our own css scripts should be
able to handle most if not all of the work for styling these widgets in the
respective contrasts. Integrators would still be able to create their own
versions of jQuery UI themes if needed or could provide the necessary
overrides.



I propose that a part of the work for FLUID-6297
<https://issues.fluidproject.org/browse/FLUID-6297> we remove the jQuery UI
contrast themes from the repo. We will need to leave the default theme
which is used for styling the tooltips used by inline edit and pager.



Please let me know what you think. I’d ideally like to continue working on
this by the end of this week or the beginning of next.



Thanks

Justin
___
fluid-work mailing list - fluid-work@lists.idrc.ocad.ca
To unsubscribe, change settings or access archives,
see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work

Re: Proposal to remove contrast themes for jQuery UI

[Harnum, Alan]

+1

From: fluid-work  on behalf of Justin 
Obara 
Date: Wednesday, July 11, 2018 at 2:38 PM
To: Fluid Work 
Subject: Proposal to remove contrast themes for jQuery UI

I’ve been looking at adding some additional low contrast themes for the 
contrast preference in UI Options (See: 
FLUID-6297<https://issues.fluidproject.org/browse/FLUID-6297> . In the process 
of working on that I noticed that the jQuery UI contrast 
themes<https://github.com/fluid-project/infusion/tree/master/src/lib/jquery/ui/css>
 are not actually being used. There were several references to them for use by 
the prefs framework panels/adjusters; however they were not actually required 
there. They most likely fell out of need when we switched off of the jQuery UI 
Sliders in favour of our own native sliders and steppers.

Originally the jQuery UI contrast themes were provided as a way to add jQuery 
UI specific styling created with their 
themeroller<https://jqueryui.com/themeroller/> tool. Our own css scripts should 
be able to handle most if not all of the work for styling these widgets in the 
respective contrasts. Integrators would still be able to create their own 
versions of jQuery UI themes if needed or could provide the necessary overrides.

I propose that a part of the work for 
FLUID-6297<https://issues.fluidproject.org/browse/FLUID-6297> we remove the 
jQuery UI contrast themes from the repo. We will need to leave the default 
theme which is used for styling the tooltips used by inline edit and pager.

Please let me know what you think. I’d ideally like to continue working on this 
by the end of this week or the beginning of next.

Thanks
Justin

___
fluid-work mailing list - fluid-work@lists.idrc.ocad.ca
To unsubscribe, change settings or access archives,
see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work

Proposal to remove contrast themes for jQuery UI

[Justin Obara]

I’ve been looking at adding some additional low contrast themes for the
contrast preference in UI Options (See: FLUID-6297
 . In the process of
working on that I noticed that the jQuery UI contrast themes

are
not actually being used. There were several references to them for use by
the prefs framework panels/adjusters; however they were not actually
required there. They most likely fell out of need when we switched off of
the jQuery UI Sliders in favour of our own native sliders and steppers.

Originally the jQuery UI contrast themes were provided as a way to add
jQuery UI specific styling created with their themeroller
 tool. Our own css scripts should be
able to handle most if not all of the work for styling these widgets in the
respective contrasts. Integrators would still be able to create their own
versions of jQuery UI themes if needed or could provide the necessary
overrides.

I propose that a part of the work for FLUID-6297
 we remove the jQuery UI
contrast themes from the repo. We will need to leave the default theme
which is used for styling the tooltips used by inline edit and pager.

Please let me know what you think. I’d ideally like to continue working on
this by the end of this week or the beginning of next.

Thanks
Justin
___
fluid-work mailing list - fluid-work@lists.idrc.ocad.ca
To unsubscribe, change settings or access archives,
see https://lists.idrc.ocad.ca/mailman/listinfo/fluid-work